Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #27843
What is the current behavior?
createInlineOverlayComponentrenders inline overlays (modal, popover, etc.) inside a<template>at their declared JSX position. When the overlay presents,CoreDelegateteleports the DOM node intoion-app, but React's synthetic event delegation root stays at the original JSX parent. Once the overlay lives outside that subtree, React no longer dispatches events to children inside it, soonClick,onChange, and other handlers inside anIonModalrendered within anIonNavsilently stop firingWhat is the new behavior?
Top-level inline overlays now render through
createPortalinto the sameion-appcontainer thatCoreDelegateteleports into, so React's event root follows the DOMDoes this introduce a breaking change?
Other information
This issue also reports the same problem in Vue, but that was fixed in #30227
Preview: navigation-modal
Dev build: