-
Notifications
You must be signed in to change notification settings - Fork 13.3k
fix(datetime): fix overlap in datetime-button modal from datetime being too short #31274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
droc101
wants to merge
5
commits into
ionic-team:main
Choose a base branch
from
droc101:29589
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
331d518
fix(datetime): fix datetime in datetime-button modal being too short
droc101 82d894b
fix(datetime): only apply min-height of 350px in ios mode
droc101 5024d0c
fix(datetime): set min-height on iOS calendar-body to prevent selecti…
droc101 c44c37a
fix(datetime): changes from code review
droc101 5cc68ad
test(datetime, item): update snapshots for datetime sizing changes
droc101 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+2.7 KB
(110%)
...-button.e2e.ts-snapshots/datetime-overlay-modal-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.44 KB
(88%)
...button.e2e.ts-snapshots/datetime-overlay-modal-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+203 Bytes
(100%)
...-button.e2e.ts-snapshots/datetime-overlay-modal-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2.51 KB
(110%)
...utton.e2e.ts-snapshots/datetime-overlay-popover-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+285 Bytes
(100%)
...utton.e2e.ts-snapshots/datetime-overlay-popover-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-972 Bytes
(97%)
...t/a11y/datetime.e2e.ts-snapshots/datetime-scale-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.49 KB
(90%)
.../a11y/datetime.e2e.ts-snapshots/datetime-scale-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+234 Bytes
(100%)
...t/a11y/datetime.e2e.ts-snapshots/datetime-scale-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+552 Bytes
(100%)
...time.e2e.ts-snapshots/date-month-toggle-focused-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.72 KB
(93%)
...ime.e2e.ts-snapshots/date-month-toggle-focused-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+534 Bytes
(100%)
...time.e2e.ts-snapshots/date-month-toggle-focused-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+502 Bytes
(100%)
...me.e2e.ts-snapshots/datetime-focus-calendar-day-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.86 KB
(93%)
...e.e2e.ts-snapshots/datetime-focus-calendar-day-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+533 Bytes
(100%)
...me.e2e.ts-snapshots/datetime-focus-calendar-day-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+503 Bytes
(100%)
...-snapshots/datetime-focus-selected-calendar-day-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.87 KB
(93%)
...snapshots/datetime-focus-selected-calendar-day-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+533 Bytes
(100%)
...-snapshots/datetime-focus-selected-calendar-day-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+530 Bytes
(100%)
...e.e2e.ts-snapshots/datetime-footer-clear-button-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.58 KB
(94%)
....e2e.ts-snapshots/datetime-footer-clear-button-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+579 Bytes
(100%)
...e.e2e.ts-snapshots/datetime-footer-clear-button-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+547 Bytes
(100%)
...e.e2e.ts-snapshots/datetime-footer-clear-button-ios-rtl-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.37 KB
(95%)
....e2e.ts-snapshots/datetime-footer-clear-button-ios-rtl-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+589 Bytes
(100%)
...e.e2e.ts-snapshots/datetime-footer-clear-button-ios-rtl-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+522 Bytes
(100%)
...e2e.ts-snapshots/datetime-footer-custom-buttons-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.58 KB
(94%)
...2e.ts-snapshots/datetime-footer-custom-buttons-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+582 Bytes
(100%)
...e2e.ts-snapshots/datetime-footer-custom-buttons-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+544 Bytes
(100%)
...e2e.ts-snapshots/datetime-footer-custom-buttons-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.37 KB
(95%)
...2e.ts-snapshots/datetime-footer-custom-buttons-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+592 Bytes
(100%)
...e2e.ts-snapshots/datetime-footer-custom-buttons-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+512 Bytes
(100%)
...2e.ts-snapshots/datetime-footer-default-buttons-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.58 KB
(94%)
...e.ts-snapshots/datetime-footer-default-buttons-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+581 Bytes
(100%)
...2e.ts-snapshots/datetime-footer-default-buttons-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+530 Bytes
(100%)
...2e.ts-snapshots/datetime-footer-default-buttons-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.38 KB
(95%)
...e.ts-snapshots/datetime-footer-default-buttons-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+586 Bytes
(100%)
...2e.ts-snapshots/datetime-footer-default-buttons-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+513 Bytes
(100%)
...snapshots/datetime-footer-default-clear-buttons-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.57 KB
(95%)
...napshots/datetime-footer-default-clear-buttons-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+579 Bytes
(100%)
...snapshots/datetime-footer-default-clear-buttons-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+545 Bytes
(100%)
...snapshots/datetime-footer-default-clear-buttons-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.37 KB
(95%)
...napshots/datetime-footer-default-clear-buttons-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+591 Bytes
(100%)
...snapshots/datetime-footer-default-clear-buttons-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-119 Bytes
(91%)
...e2e.ts-snapshots/datetime-today-calendar-button-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+150 Bytes
(110%)
...2e.ts-snapshots/datetime-today-calendar-button-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-25 Bytes
(98%)
...e2e.ts-snapshots/datetime-today-calendar-button-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+2.72 KB
(110%)
.../color/datetime.e2e.ts-snapshots/datetime-color-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.4 KB
(110%)
...color/datetime.e2e.ts-snapshots/datetime-color-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.68 KB
(110%)
.../color/datetime.e2e.ts-snapshots/datetime-color-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+3.35 KB
(120%)
...r/datetime.e2e.ts-snapshots/datetime-color-ios-ltr-dark-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.36 KB
(110%)
.../datetime.e2e.ts-snapshots/datetime-color-ios-ltr-dark-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.86 KB
(110%)
...r/datetime.e2e.ts-snapshots/datetime-color-ios-ltr-dark-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+243 Bytes
(100%)
....e2e.ts-snapshots/datetime-custom-calendar-days-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.91 KB
(94%)
...e2e.ts-snapshots/datetime-custom-calendar-days-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+680 Bytes
(100%)
....e2e.ts-snapshots/datetime-custom-calendar-days-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+252 Bytes
(100%)
...ts-snapshots/datetime-custom-focus-calendar-day-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.09 KB
(94%)
...s-snapshots/datetime-custom-focus-calendar-day-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+654 Bytes
(100%)
...ts-snapshots/datetime-custom-focus-calendar-day-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+262 Bytes
(100%)
...ots/datetime-custom-focus-selected-calendar-day-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.01 KB
(94%)
...ts/datetime-custom-focus-selected-calendar-day-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+620 Bytes
(100%)
...ots/datetime-custom-focus-selected-calendar-day-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-91 Bytes
(95%)
...s-snapshots/datetime-custom-time-button-active-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-84 Bytes
(99%)
...me.e2e.ts-snapshots/datetime-custom-time-picker-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+764 Bytes
(100%)
...led/datetime.e2e.ts-snapshots/datetime-disabled-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.31 KB
(95%)
...ed/datetime.e2e.ts-snapshots/datetime-disabled-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.03 KB
(100%)
...led/datetime.e2e.ts-snapshots/datetime-disabled-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+173 Bytes
(100%)
...me.e2e.ts-snapshots/datetime-display-cover-date-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.91 KB
(88%)
...e.e2e.ts-snapshots/datetime-display-cover-date-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+245 Bytes
(100%)
...me.e2e.ts-snapshots/datetime-display-cover-date-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+471 Bytes
(100%)
...e.ts-snapshots/datetime-display-cover-date-time-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.64 KB
(90%)
....ts-snapshots/datetime-display-cover-date-time-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+631 Bytes
(100%)
...e.ts-snapshots/datetime-display-cover-date-time-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+470 Bytes
(100%)
...e.ts-snapshots/datetime-display-cover-time-date-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.56 KB
(90%)
....ts-snapshots/datetime-display-cover-time-date-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+633 Bytes
(100%)
...e.ts-snapshots/datetime-display-cover-time-date-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+178 Bytes
(100%)
...datetime.e2e.ts-snapshots/datetime-display-date-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.09 KB
(91%)
...atetime.e2e.ts-snapshots/datetime-display-date-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+192 Bytes
(100%)
...datetime.e2e.ts-snapshots/datetime-display-date-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+459 Bytes
(100%)
...ime.e2e.ts-snapshots/datetime-display-date-time-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.75 KB
(93%)
...me.e2e.ts-snapshots/datetime-display-date-time-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+539 Bytes
(100%)
...ime.e2e.ts-snapshots/datetime-display-date-time-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+458 Bytes
(100%)
...ime.e2e.ts-snapshots/datetime-display-time-date-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.75 KB
(93%)
...me.e2e.ts-snapshots/datetime-display-time-date-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+524 Bytes
(100%)
...ime.e2e.ts-snapshots/datetime-display-time-date-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+510 Bytes
(100%)
.../datetime.e2e.ts-snapshots/datetime-day-of-week-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.64 KB
(94%)
...datetime.e2e.ts-snapshots/datetime-day-of-week-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+625 Bytes
(100%)
.../datetime.e2e.ts-snapshots/datetime-day-of-week-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+525 Bytes
(100%)
.../datetime.e2e.ts-snapshots/datetime-day-of-week-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.57 KB
(94%)
...datetime.e2e.ts-snapshots/datetime-day-of-week-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+629 Bytes
(100%)
.../datetime.e2e.ts-snapshots/datetime-day-of-week-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+221 Bytes
(100%)
...2e.ts-snapshots/datetime-highlightedDates-array-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.14 KB
(93%)
...e.ts-snapshots/datetime-highlightedDates-array-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+243 Bytes
(100%)
...2e.ts-snapshots/datetime-highlightedDates-array-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+457 Bytes
(100%)
...ts-snapshots/datetime-highlightedDates-callback-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.24 KB
(94%)
...s-snapshots/datetime-highlightedDates-callback-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+75 Bytes
(100%)
...ts-snapshots/datetime-highlightedDates-callback-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+257 Bytes
(100%)
...napshots/datetime-highlightedDates-single-color-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.13 KB
(93%)
...apshots/datetime-highlightedDates-single-color-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+240 Bytes
(100%)
...napshots/datetime-highlightedDates-single-color-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+2.84 KB
(120%)
...ime.e2e.ts-snapshots/datetime-locale-en-US-diff-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1020 Bytes
(96%)
...me.e2e.ts-snapshots/datetime-locale-en-US-diff-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+784 Bytes
(100%)
...ime.e2e.ts-snapshots/datetime-locale-en-US-diff-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+2.85 KB
(120%)
...ime.e2e.ts-snapshots/datetime-locale-es-ES-diff-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.02 KB
(96%)
...me.e2e.ts-snapshots/datetime-locale-es-ES-diff-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+786 Bytes
(100%)
...ime.e2e.ts-snapshots/datetime-locale-es-ES-diff-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+2.86 KB
(120%)
...ime.e2e.ts-snapshots/datetime-locale-ja-JP-diff-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1003 Bytes
(96%)
...me.e2e.ts-snapshots/datetime-locale-ja-JP-diff-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+779 Bytes
(100%)
...ime.e2e.ts-snapshots/datetime-locale-ja-JP-diff-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+190 Bytes
(100%)
...apshots/datetime-multiple-multipleDefaultValues-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.04 KB
(91%)
...pshots/datetime-multiple-multipleDefaultValues-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+207 Bytes
(100%)
...apshots/datetime-multiple-multipleDefaultValues-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+200 Bytes
(100%)
...apshots/datetime-multiple-multipleDefaultValues-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.14 KB
(91%)
...pshots/datetime-multiple-multipleDefaultValues-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+212 Bytes
(100%)
...apshots/datetime-multiple-multipleDefaultValues-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+178 Bytes
(100%)
...-snapshots/datetime-multiple-singleDefaultValue-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.06 KB
(91%)
...snapshots/datetime-multiple-singleDefaultValue-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+199 Bytes
(100%)
...-snapshots/datetime-multiple-singleDefaultValue-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+161 Bytes
(100%)
...-snapshots/datetime-multiple-singleDefaultValue-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.11 KB
(91%)
...snapshots/datetime-multiple-singleDefaultValue-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+199 Bytes
(100%)
...-snapshots/datetime-multiple-singleDefaultValue-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+599 Bytes
(100%)
...e.e2e.ts-snapshots/datetime-multiple-withHeader-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.54 KB
(94%)
....e2e.ts-snapshots/datetime-multiple-withHeader-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+668 Bytes
(100%)
...e.e2e.ts-snapshots/datetime-multiple-withHeader-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+585 Bytes
(100%)
...e.e2e.ts-snapshots/datetime-multiple-withHeader-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.62 KB
(94%)
....e2e.ts-snapshots/datetime-multiple-withHeader-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+662 Bytes
(100%)
...e.e2e.ts-snapshots/datetime-multiple-withHeader-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+33 Bytes
(100%)
...atetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-5.13 KB
(87%)
...tetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+25 Bytes
(100%)
...atetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+41 Bytes
(100%)
...atetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.98 KB
(95%)
...tetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+25 Bytes
(100%)
...atetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-3.21 KB
(89%)
...time.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-6.87 KB
(86%)
...ime.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+367 Bytes
(100%)
...time.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-3.15 KB
(89%)
...time.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-6.93 KB
(85%)
...ime.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+229 Bytes
(100%)
...time.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+245 Bytes
(100%)
...-snapshots/datetime-presentation-date-time-diff-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.15 KB
(92%)
...snapshots/datetime-presentation-date-time-diff-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+195 Bytes
(100%)
...-snapshots/datetime-presentation-date-time-diff-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+254 Bytes
(100%)
...-snapshots/datetime-presentation-date-time-diff-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.05 KB
(92%)
...snapshots/datetime-presentation-date-time-diff-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+197 Bytes
(100%)
...-snapshots/datetime-presentation-date-time-diff-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+244 Bytes
(100%)
...-snapshots/datetime-presentation-time-date-diff-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.13 KB
(92%)
...snapshots/datetime-presentation-time-date-diff-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+186 Bytes
(100%)
...-snapshots/datetime-presentation-time-date-diff-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+255 Bytes
(100%)
...-snapshots/datetime-presentation-time-date-diff-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.03 KB
(92%)
...snapshots/datetime-presentation-time-date-diff-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+186 Bytes
(100%)
...-snapshots/datetime-presentation-time-date-diff-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+868 Bytes
(100%)
...nly/datetime.e2e.ts-snapshots/datetime-readonly-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.27 KB
(95%)
...ly/datetime.e2e.ts-snapshots/datetime-readonly-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+905 Bytes
(100%)
...nly/datetime.e2e.ts-snapshots/datetime-readonly-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+214 Bytes
(100%)
...ots/datetime-show-adjacent-days-custom-calendar-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.18 KB
(94%)
...ts/datetime-show-adjacent-days-custom-calendar-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+392 Bytes
(100%)
...ots/datetime-show-adjacent-days-custom-calendar-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+543 Bytes
(100%)
...datetime-show-adjacent-days-date-range-disabled-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.54 KB
(95%)
...atetime-show-adjacent-days-date-range-disabled-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+616 Bytes
(100%)
...datetime-show-adjacent-days-date-range-disabled-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+621 Bytes
(100%)
...s-snapshots/datetime-show-adjacent-days-display-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.38 KB
(95%)
...-snapshots/datetime-show-adjacent-days-display-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+622 Bytes
(100%)
...s-snapshots/datetime-show-adjacent-days-display-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+589 Bytes
(100%)
...me.e2e.ts-snapshots/datetime-show-adjacent-days-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.52 KB
(95%)
...e.e2e.ts-snapshots/datetime-show-adjacent-days-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+604 Bytes
(100%)
...me.e2e.ts-snapshots/datetime-show-adjacent-days-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+518 Bytes
(100%)
...hots/datetime-show-adjacent-days-month-disabled-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.52 KB
(95%)
...ots/datetime-show-adjacent-days-month-disabled-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+662 Bytes
(100%)
...hots/datetime-show-adjacent-days-month-disabled-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+538 Bytes
(100%)
...etime-show-adjacent-days-specific-date-disabled-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.57 KB
(95%)
...time-show-adjacent-days-specific-date-disabled-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+682 Bytes
(100%)
...etime-show-adjacent-days-specific-date-disabled-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+603 Bytes
(100%)
...s/datetime-show-adjacent-days-weekends-disabled-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.56 KB
(95%)
.../datetime-show-adjacent-days-weekends-disabled-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+686 Bytes
(100%)
...s/datetime-show-adjacent-days-weekends-disabled-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+123 Bytes
(100%)
...puts/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-5.54 KB
(87%)
...uts/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+249 Bytes
(100%)
...puts/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+226 Bytes
(100%)
...m/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-5.36 KB
(89%)
.../test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+271 Bytes
(100%)
...m/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+203 Bytes
(100%)
...m/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-5.35 KB
(89%)
.../test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+246 Bytes
(100%)
...m/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We landed on flooring the row at the circle size instead of setting a height on the calendar body. It keeps the rows collapsible enough to distribute like native, but stops them shrinking under the circle, which is what caused the overlap. This also covers the inline case, not just the overlay.
// datetime.ios.scss
:host .calendar-day-wrapper { @include padding(4px); // This is required so that the calendar day wrapper // will collapse instead of expanding to fill the button height: 0; - min-height: dynamic-font(16px); + min-height: calc(#{$datetime-ios-day-height} + 2px); }Please also remove the
:host .calendar-body { min-height: 282px }rule you added, since this replaces it.