Skip to content

chore(deps): transitively update postcss #31436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OS-jacobbell wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore(deps): transitively update postcss #31436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
907f9b2
chore(deps): transitively update postcss
OS-jacobbell Sep 8, 2026
faaafa5
revert stylelint version
OS-jacobbell Sep 8, 2026
0dc8ad9
override core stylelint postcss dep
OS-jacobbell Sep 8, 2026
14aeb05
revert core package changes
OS-jacobbell Sep 9, 2026
9dab552
update angular-server package-lock
OS-jacobbell Sep 11, 2026
af4cbae
chore: trigger ci
thetaPC Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6,342 changes: 1,201 additions & 5,141 deletions packages/angular-server/package-lock.json
View file
Open in desktop

@thetaPC thetaPC Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a line in the PR description: the v2 to v3 lockfile migration is most of this file's diff.

Large diffs are not rendered by default.

34 changes: 19 additions & 15 deletions packages/angular/test/apps/ng18/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions packages/angular/test/apps/ng18/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@
"webpack": "^5.61.0",
"webpack-cli": "^4.9.2"
},
"overrides": {

@thetaPC thetaPC Sep 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on the override. I'd scoped ng18/ng19/ng20 as unfixable, since @angular-devkit/build-angular pins postcss exactly and the newest devkit in each major is still vulnerable (18 gives 8.4.41, 19 gives 8.5.12). Forcing ^8.5.23 clears all three, which takes three dismissals off FW-7722.

"postcss": "^8.5.23"
},
"engines": {
"node": ">= 18"
}
Expand Down
14 changes: 7 additions & 7 deletions packages/angular/test/apps/ng19/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions packages/angular/test/apps/ng19/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@
"webpack": "^5.61.0",
"webpack-cli": "^4.9.2"
},
"overrides": {
"postcss": "^8.5.23"
},
"engines": {
"node": ">= 18"
}
Expand Down
14 changes: 7 additions & 7 deletions packages/angular/test/apps/ng20/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions packages/angular/test/apps/ng20/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@
"webpack": "^5.61.0",
"webpack-cli": "^4.9.2"
},
"overrides": {
"postcss": "^8.5.23"
Comment thread
thetaPC marked this conversation as resolved.
},
"engines": {
"node": ">=20"
}
Expand Down
Loading