Skip to content

Create fr.nsi#1125

Merged
hoffie merged 6 commits into
jamulussoftware:masterfrom
jujudusud:patch-2
Feb 27, 2021
Merged

Create fr.nsi#1125
hoffie merged 6 commits into
jamulussoftware:masterfrom
jujudusud:patch-2

Conversation

@jujudusud

Copy link
Copy Markdown
Member

Creating the french translation of windows installer.

Creating the french translation of windows installer.
Adding French macro.
Comment thread src/res/translation/wininstaller/fr.nsi Outdated
Adding Asio anchor.

@ann0see ann0see left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks.

Comment thread src/res/translation/wininstaller/fr.nsi Outdated
updating with ${LANG_FRENCH}
@ann0see ann0see self-requested a review February 26, 2021 21:56

@ann0see ann0see left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. There's still a mistake I didn’t see at first here.

Comment thread src/res/translation/wininstaller/fr.nsi Outdated
Deleting droit spaces between $ and {APPNAME}.

@ann0see ann0see left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to look good.

@ann0see ann0see added this to the Release 3.7.0 milestone Feb 27, 2021
@jujudusud

Copy link
Copy Markdown
Member Author

Thanks a lot @ann0see for your reviews and your help ! :-)

@ann0see ann0see requested review from a team and removed request for a team February 27, 2021 17:04
@hoffie hoffie mentioned this pull request Feb 27, 2021
39 tasks

@hoffie hoffie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your work!

  • Translator listed in the src/util.cpp #1128
  • Looks consistent
  • Passes tools/check-wininstaller-translations.sh

@hoffie hoffie merged commit b3dd660 into jamulussoftware:master Feb 27, 2021
@trebmuh

trebmuh commented Mar 6, 2021

Copy link
Copy Markdown
Member

nice

@jujudusud jujudusud deleted the patch-2 branch March 6, 2021 21:59
@pljones pljones moved this from Triage to Done in Tracking Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants