Skip to content

Update pt_PT translation#1168

Merged
softins merged 1 commit into
jamulussoftware:masterfrom
Snayler:master
Mar 3, 2021
Merged

Update pt_PT translation#1168
softins merged 1 commit into
jamulussoftware:masterfrom
Snayler:master

Conversation

@Snayler

@Snayler Snayler commented Mar 3, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@hoffie hoffie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your work! Looks good to me.

  • Translator listed in the src/util.cpp
    "<p>Miguel de Matos (<a href=\"https://github.com/Snayler\">Snayler</a>)</p>"
  • Punctuation and spacing consistent
  • Signal words consistent ("ASIO", "Buffer")
  • No untranslated strings (grep unfinished -5 src/res/translation/translation_$TRANSLTION*.ts)
  • Only a single .ts file checked in (+.qm which is known to be not a problem)

@Snayler

Snayler commented Mar 3, 2021

Copy link
Copy Markdown
Contributor Author
* [x]  Only a single `.ts` file checked in (+.qm which is known to be not a problem)

So no need for the .qm file next file I do the translations?

@hoffie

hoffie commented Mar 3, 2021

Copy link
Copy Markdown
Member

So no need for the .qm file next file I do the translations?

As far as I understand: Yes, there's no need for you to check that in all required files will be generated as part of the release process. :)
It's no issue either though.

@softins softins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I couldn't find any conflicting accelerator keys.

@softins softins merged commit 090e8ac into jamulussoftware:master Mar 3, 2021
@ann0see ann0see mentioned this pull request Mar 4, 2021
39 tasks
@pljones pljones added this to the Release 3.7.0 milestone Nov 24, 2024
@pljones pljones moved this from Triage to Done in Tracking Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants