Automated build for Android APK#878
Conversation
Co-Authored-By: nefarius2001 <nefarius2001@users.noreply.github.com>
Co-Authored-By: ranfdev <ranfdev@users.noreply.github.com>
This reverts commit b6feab3. keeps additional mirror parameter as comment
|
Wow, I am very impressed! I saw that you also did some changes in the Windows installer script (deploy_windows.ps1). @ann0see, have you already reviewed that part? |
|
@ann0see BTW, what is the best way to write you a PM? |
|
I've rewritten the windows part. I will have a look at these changes soon. |
|
@corrados you can have a look at the billing E-Mail address in the jamulussoftware Organisation and I can afterwards send you my private E-Mail Adress, Threema ID/Signal number,... |
|
I would still like, if possible, the CodeQL checks run against this -- if CodeQL doesn't support scanning the Android code, fair enough, though. |
I agree, CodeQL check makes sense. But we should get rid of the Travis builds, don't we? |
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
A few comments.
Same problem as you had with my PR: commit history ;-)
| # Install Qt | ||
| pip install aqtinstall | ||
| echo "Get Qt 64 bit..." | ||
| # intermediate solution if the main server is down: append e.g. " -b https://mirrors.ocf.berkeley.edu/qt/" to the "aqt"-line below |
There was a problem hiding this comment.
A fallback argument has been added to aqt recently. Maybe we could use this?
There was a problem hiding this comment.
good idea. I hop I will not forget this.
Likely I will make the qt-install in Android build aqt based, too
|
opened new PR with nicer git history (opened PR from master and not branch by mistake) please continue discussion there: |
4 participants
Credit and thanks to @ann0see for contributing & support
Resolves #835 Automated build for Android APK
open/related issues, that I see as upcomming improvements, but not part of this PR/issue:
#856 harmonized folders
#857 multiple APK-platforms
this PR creates automatically:
I ask you to accept the PR with this minimal behaviour and lets continue the discussion about behaviour in Automated github builds #854
The build process for android can be improved still, but I think it is already very good to have a working state as basis.