Skip to content

tutorial 1 on refactoring to functional style#29

Merged
carimura merged 4 commits into
mainfrom
refactoring
Jul 12, 2023
Merged

tutorial 1 on refactoring to functional style#29
carimura merged 4 commits into
mainfrom
refactoring

Conversation

@venkats

@venkats venkats commented Jul 6, 2023

Copy link
Copy Markdown
Collaborator

tutorial 1 on refactoring is ready for review and suggestions. Thank you.

@oracle-contributor-agreement

oracle-contributor-agreement Bot commented Jul 6, 2023

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jul 6, 2023
@carimura

carimura commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

BTW I also just merged back in a CSS file that should render your code blocks.

carimura
carimura suggested changes Jul 10, 2023
View reviewed changes

@carimura carimura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments, thanks!

Comment thread ...etting-to-know-the-language/03_refactoring_to_functional_style/01_converting_simple_loops.md Outdated
Comment thread ...etting-to-know-the-language/03_refactoring_to_functional_style/01_converting_simple_loops.md Outdated
@carimura
carimura self-requested a review July 11, 2023 16:56
@oracle-contributor-agreement

oracle-contributor-agreement Bot commented Jul 11, 2023

Copy link
Copy Markdown

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement Bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Jul 11, 2023
carimura
carimura suggested changes Jul 11, 2023
View reviewed changes

@carimura carimura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few fixes before merging!

@carimura
carimura merged commit 91a9a00 into main Jul 12, 2023
@carimura
carimura deleted the refactoring branch July 12, 2023 23:19
@carimura
carimura restored the refactoring branch July 12, 2023 23:19
@carimura

carimura commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

Congratulations @venkats you're the first PR to be merged. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@carimura carimura carimura approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@venkats @carimura