Skip to content

cert article ready for review#33

Merged
carimura merged 8 commits into
mainfrom
cert-jeanne
Sep 5, 2023
Merged

cert article ready for review#33
carimura merged 8 commits into
mainfrom
cert-jeanne

Conversation

@boyarsky

@boyarsky boyarsky commented Aug 1, 2023

Copy link
Copy Markdown
Collaborator

I know I didn't add it to the category/tree right. So I could use guidance on that along with any feedback you have on the article itself.

This is for issue #31

@netlify

netlify Bot commented Aug 1, 2023

Copy link
Copy Markdown

Deploy Preview for devjava-content ready!

Name Link
🔨 Latest commit 169c4c6
🔍 Latest deploy log https://app.netlify.com/sites/devjava-content/deploys/64f6b094783cce0008cc7331
😎 Deploy Preview https://deploy-preview-33--devjava-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 1, 2023
@carimura

Copy link
Copy Markdown
Contributor

Thanks @boyarsky ! We'll review and also consider where it should be categorized. I'm leaning towards thinking about a new section for this but then it might be kind of lonely.

@carimura

Copy link
Copy Markdown
Contributor

cc @monoquito89 @SharatChander for reviews.

@boyarsky

Copy link
Copy Markdown
Collaborator Author

@carimura I could solve the "lonely" problem by writing another article. (I'd like to get feedback on this one first though).

If the category is certs, maybe an article on 5 sample questions for your choice if Java 17 or 21 and explanations. If the category is education, maybe showing easy ways to start coding (online ide, jshell, new main method)

@carimura

Copy link
Copy Markdown
Contributor

Maybe a "Furthering your Education" section that points out to other resources. thoughts @nipafx @JosePaumard?

@monoquito89

Copy link
Copy Markdown

Sorry for the delay Jeanne. I had to double-check some things with Oracle University to be sure we didn't miss anything, and the person for that has been on business travel.

I truly love that you are taking on this subject. Thank you!

Since this is an article, I figured comments might be easier to deal with in a word doc so I attached that here. If that's wrong, tell me, and I'll comment the individual lines in the PR. Just lmk!

Certifications for devdotjava.docx

@boyarsky

Copy link
Copy Markdown
Collaborator Author

Thanks @monoquito89 . I think I addressed all your comments except the 811 (of which you need to look something up.)

Either Word doc or inline is fine. I'll write my second article within the week. I was waiting for feedback on this one. After all, no reason to write two articles only to find out you missed something critical in process or style!

@monoquito89

Copy link
Copy Markdown

@boyarsky - Thanks! @carimura - My recommendation for 811 is that we just go with it as Jeanne wrote it. We can ask for a change later if we discover something nuanced worth mentioning.

@monoquito89 monoquito89 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of submitting this @carimura. Jeanne's perspective is a valuable inclusion!

learn page. It currently appears under the first section,
which can be changed later.
@oracle-contributor-agreement oracle-contributor-agreement Bot added OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. and removed OCA Verified All contributors have signed the Oracle Contributor Agreement. labels Aug 31, 2023
@oracle-contributor-agreement

Copy link
Copy Markdown

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement Bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Aug 31, 2023
@java java deleted a comment from oracle-contributor-agreement Bot Aug 31, 2023
@JosePaumard
JosePaumard self-requested a review August 31, 2023 12:39
@carimura

Copy link
Copy Markdown
Contributor

hey @boyarsky, when you say "I think I addressed all your comments" -- did you commit some changes? If so, maybe I'm missing them as the only commits have been by José since the original PR creation. Thanks!

@carimura

Copy link
Copy Markdown
Contributor

Oh @monoquito89 just pointed this out 8991fe7

great!

@oracle-contributor-agreement

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement Bot added OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. and removed OCA Verified All contributors have signed the Oracle Contributor Agreement. labels Sep 5, 2023
@carimura
carimura removed the request for review from SharatChander September 5, 2023 04:38
@carimura carimura added approved OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Sep 5, 2023
@carimura
carimura merged commit f764453 into main Sep 5, 2023
@boyarsky
boyarsky deleted the cert-jeanne branch September 10, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants