debugging article ready for review#57
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
wkorando
left a comment
wkorando
left a comment
There was a problem hiding this comment.
Love the article Jeanne! It is a great introduction to both why and how to use a debugger. Only noticed a few minor typos and a few formatting changes that need to be made.
There was a problem hiding this comment.
I really look forward to this article being added. Here are a few things I feel are still missing:
- I didn't see anything explaining that a breakpoint can be set by the developer (and how to do it). I am not sure whether someone not knowing about debuggers would realize how to do that from reading the article. It might be a good idea to note that breakpoints can (in most IDEs) be set by clicking next to the lines.
- While you added
EvaluationunderAdvanced Techniques, you don't seem to explain anything related to viewing variables which is (in my opinion) a central part of debugging. - Your
magic()example shows the discovery of a bug but how do developers know where to place breakpoints? It might be useful to also add a slightly more complicated example showing how a bug can be found.
Disclaimer: I am just an outside developer who wants to use the article for reference when talking to others. I have no authority here (these are just suggestions) and I am not affiliated or associated with Oracle.
|
Replied to all the easy comments :). The ones I didn't reply to are because I didn't have enough time before my 7pm call, not because I disagree. I'll look at those later tonight or tomorrow. |
|
I think I replied to everything now |
wkorando
left a comment
wkorando
left a comment
There was a problem hiding this comment.
Just a couple more small changes, but otherwise, it looks good to me!
danthe1st
left a comment
danthe1st
left a comment
There was a problem hiding this comment.
While reading over it, I found two small details that might still be worth looking into.
danthe1st
left a comment
danthe1st
left a comment
There was a problem hiding this comment.
As the person suggesting/requesting an article on debugging, I really like how this has turned out.
|
hey @danthe1st @wkorando appears there are two "conversations" that need resolved and it appears ya'll might be on point with them. If you resolve I can get this merged and deployed! |
|
I don't have the permissions to mark conversations as resolved (also not on my own review comments). However,it seems like all of my comments (unless maybe the links which seems to be fine) have been addressed. |
|
All resolved. One was open because I made an edit in response to Dan's comment last night so I wanted to give him 24 hours to read what I wrote. (Thanks for the confirmation Dan.) The other I had already addressed but miss the resolve button. |
|
Excellent thank you @boyarsky for the great article and @danthe1st @wkorando for the review! I'll get this deployed soon! |
|
This has been merged to prod and deployed. Thanks again! |
4 participants
This is the article for request #43