Minor grammar/spelling edits#153
Conversation
Double checked, should be good. Just pay attention to line 296 as I'm not 100% sure it's the correct edit in this context.
iliakan
left a comment
iliakan
left a comment
There was a problem hiding this comment.
Great work! Please take a look at two minor comments here.
| ``` | ||
|
|
||
| This gives great flexibility, but also an interesting problem: the same symbol visually can be represented with different unicode compositions. | ||
| This provides great flexibility, but also an interesting problem: the same symbol can be visually represented with different unicode compositions. |
There was a problem hiding this comment.
Sorry for my bad English, actually the idea was that different unicode compositions may represent the same visual character (see the example below).
The word "visually" referred to "the same symbol", not to "unicode composition".
There was a problem hiding this comment.
If the word 'visually' is needed to let the reader understand that the symbol looks the same but in the unicode it's actually different, then maybe use:
'this same symbol can be represented with different unicode compositions, but still visually look the same'.
There was a problem hiding this comment.
"This provides great flexibility, but also an interesting problem: two characters may visually look the same, but be represented with different unicode compositions." - ok?
There was a problem hiding this comment.
please update the PR then, so that I can accept it along with other changes :)
| ``` | ||
|
|
||
| In real, that is not always so. The reason is that symbol `Ṩ` is "common enough", so UTF-16 creators included it into the main table and gave it the code. | ||
| In reality, this is not always the case. The reason being that the symbol `Ṩ` is "common enough", so UTF-16 creators included it in the main table and gave it to the code. |
There was a problem hiding this comment.
This is a difficult statement to interpret (from my beginner point-of-view).
Are you saying here that:
"S\u0307\u0323".normalize() == "\u1e68" // true
because UTF-16 includes the Ṩ symbol in the spec, but not all symbols are included in this spec., so .normalize will not always translate to 'true'?
If I misunderstand this part, then I will leave your original wording so that it is technically correct.
There was a problem hiding this comment.
I mean that "S\u0307\u0323" gets normalized to a single character, because the symbol "s with two dots" is very common and has a separate code.
There was a problem hiding this comment.
Hmm I think the wording should stay then, and just remove 'to'.
2 participants
Double checked, should be good. Just pay attention to line 296 as I'm not 100% sure it's the correct edit in this context.