Skip to content

Improve make-army task#2127

Merged
iliakan merged 1 commit into
javascript-tutorial:masterfrom
MuhammedZakir:master
Sep 23, 2020
Merged

Improve make-army task#2127
iliakan merged 1 commit into
javascript-tutorial:masterfrom
MuhammedZakir:master

Conversation

@MuhammedZakir

@MuhammedZakir MuhammedZakir commented Sep 18, 2020

Copy link
Copy Markdown
Contributor

Fix grammar and indent some paragraphs.

Complements #2081.

Fix grammar and indent some paragraphs.
Complements javascript-tutorial#2081.
@iliakan iliakan merged commit c48c52c into javascript-tutorial:master Sep 23, 2020
@iliakan

iliakan commented Sep 23, 2020

Copy link
Copy Markdown
Member

Had to make a few amendments in commit e61bfa2

@MuhammedZakir

Copy link
Copy Markdown
Contributor Author

Had to make a few amendments in commit e61bfa2

I will keep that in mind. :-)

About that last one,

Now, as you've put so much effort into reading this, and the final recipe is so simple - just use `for`, you may wonder -\- was it worth that?

Without backslash, HTML output of this paragraph was strange. That's why, I added it. I forgot what the problem was though.

@iliakan

iliakan commented Sep 23, 2020

Copy link
Copy Markdown
Member

-- gets autoconverted to – (long dash) by the rendering engine.

@MuhammedZakir

MuhammedZakir commented Sep 23, 2020

Copy link
Copy Markdown
Contributor Author

-- gets autoconverted to – (long dash) by the rendering engine.

I see. So does it show correctly now? Also, how long does the site take to show updated content?

Edit: I misunderstood that sentence and, that was not the strange output I got.
Edit-2: Okay, that is indeed what I am getting now. I got it all mixed up. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants