Skip to content

The modern mode, 'use strict'#160

Merged
bogdanbacosca merged 9 commits into
javascript-tutorial:masterfrom
AurelianVirgil:Romanian_translation
Jan 4, 2023
Merged

The modern mode, 'use strict'#160
bogdanbacosca merged 9 commits into
javascript-tutorial:masterfrom
AurelianVirgil:Romanian_translation

Conversation

@AurelianVirgil

@AurelianVirgil AurelianVirgil commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Hello,

This is my translation for this article.
As this is my first contribution, please give me your feedback.

Thank you,

@javascript-translate-bot javascript-translate-bot requested a review from a team December 20, 2022 11:11
@CLAassistant

CLAassistant commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

bogdanbacosca
bogdanbacosca requested changes Dec 20, 2022
View reviewed changes

@bogdanbacosca bogdanbacosca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am adăugat câteva modificări de formatare: spații lipsă sau adăugate, virgule în plus și așa mai departe.
Traducerea în sine este bună în mare parte. Te rog să te uiți prin schimbări și dacă ai alte sugestii le putem discuta. În caz contrar, urmează fluxul de muncă.

Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Dec 20, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

AurelianVirgil and others added 5 commits December 20, 2022 16:16
@AurelianVirgil @bogdanbacosca
Update 1-js/02-first-steps/03-strict-mode/article.md
901a5df 
Co-authored-by: Bogdan Bacoșcă <bogdanbacosca@protonmail.com>
@AurelianVirgil @bogdanbacosca
Update 1-js/02-first-steps/03-strict-mode/article.md
0a058c2 
Co-authored-by: Bogdan Bacoșcă <bogdanbacosca@protonmail.com>
@AurelianVirgil @bogdanbacosca
Update 1-js/02-first-steps/03-strict-mode/article.md
8031dd7 
Co-authored-by: Bogdan Bacoșcă <bogdanbacosca@protonmail.com>
@AurelianVirgil @bogdanbacosca
Update 1-js/02-first-steps/03-strict-mode/article.md
951f6c6 
Co-authored-by: Bogdan Bacoșcă <bogdanbacosca@protonmail.com>
@AurelianVirgil @bogdanbacosca
Update 1-js/02-first-steps/03-strict-mode/article.md
997850b 
Co-authored-by: Bogdan Bacoșcă <bogdanbacosca@protonmail.com>
AurelianVirgil
AurelianVirgil commented Dec 30, 2022
View reviewed changes
Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
Comment thread 1-js/02-first-steps/03-strict-mode/article.md
Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
Comment thread 1-js/02-first-steps/03-strict-mode/article.md Outdated
bogdanbacosca
bogdanbacosca requested changes Dec 30, 2022
View reviewed changes

@bogdanbacosca bogdanbacosca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Te rog dacă se poate să modifici codul direct sau formatând sugestia folosing sintaxa:

"
```suggestion
cod
```"

Sunt foarte multe schimbări de revizuit iar o formatare corectă ar ajuta pe oricine s-ar uita peste acest PR.

@javascript-translate-bot

javascript-translate-bot commented Dec 30, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

bogdanbacosca
bogdanbacosca approved these changes Jan 4, 2023
View reviewed changes

@bogdanbacosca bogdanbacosca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traducere completă, PR aprobat

@bogdanbacosca bogdanbacosca merged commit 8ff7b52 into javascript-tutorial:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdanbacosca bogdanbacosca bogdanbacosca approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AurelianVirgil @CLAassistant @javascript-translate-bot @bogdanbacosca