Update round fraction example#1851
Merged
Merged
Conversation
In the particular example with multiplying and dividing by 100 there is no mistake. However using `Math.round` instead of `Math.floor` would be better. If it was a number `1.23567`, the rounded result would be `1.24`. But with the current `Math.floor` we still get `1.23` which is incorrect.
javascript-translate-bot
added
the
review needed
|
|
javascript-translate-bot
added
needs +1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the particular example with multiplying and dividing by 100 there is no mistake. However using
Math.roundinstead ofMath.floorwould be better. If it was a number1.23567, the rounded result would be1.24. But with the currentMath.floorwe still get1.23which is incorrect.