reload only when user release pulling and it is cross min distance then#31
Open
Sandon wants to merge 6 commits into
Open
reload only when user release pulling and it is cross min distance then#31Sandon wants to merge 6 commits into
Sandon wants to merge 6 commits into
Conversation
Owner
|
Please adjust he code style so the eslint check passes |
|
@Sandon any updated on fixing style? do you need a hand on this? |
Owner
|
This PR overlaps with #23 so I'll get that one through first and then see if this one is still nedef |
|
im a bit confused here @jsdf . What you referenced is an issue in regards to supporting Android. However, i dont see any PR for Android yet. Are you saying that first youll implemented the funcionality for Android and then, you will take a look into this PR ? |
Owner
|
Whoops, I meant to link to this: #33 |
Author
|
Yes, I need help. The Travis CI gives error messages on the origin code ( code not added by me ). I don't know how to pass the Travis. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That fixes the bug : infinitely reload if user hold the pulling as mentioned in #16
That is also a function complement : reload only when user release pulling and it is cross min distance then