Skip to content

fix: update announcement banner to use theme colors#720

Closed
saimanoharigodavarty wants to merge 1 commit into
keploy:mainfrom
saimanoharigodavarty:fix/announcement-banner-theme-colors
Closed

fix: update announcement banner to use theme colors#720
saimanoharigodavarty wants to merge 1 commit into
keploy:mainfrom
saimanoharigodavarty:fix/announcement-banner-theme-colors

Conversation

@saimanoharigodavarty
Copy link
Copy Markdown

  • Replace plain white background with theme-based gradient
  • Use primary color (#ff914d) and primary-light for attractive gradient
  • Add proper text color (white) for better contrast and visibility
  • Add border-bottom using primary-dark for visual separation
  • Support both light and dark themes
  • Style links within banner for consistency
  • Make banner more noticeable and consistent with site design

What has changed?

Please include a summary of the change.

This PR Resolves #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Documentation update (if none of the other choices apply).

How Has This Been Tested?

Please run npm run build and npm run serve to check if the changes are working as expected. Please include screenshots of the output of both the commands. Add screenshots/gif of the changes if possible.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.

- Replace plain white background with theme-based gradient
- Use primary color (#ff914d) and primary-light for attractive gradient
- Add proper text color (white) for better contrast and visibility
- Add border-bottom using primary-dark for visual separation
- Support both light and dark themes
- Style links within banner for consistency
- Make banner more noticeable and consistent with site design
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

Copy link
Copy Markdown
Contributor

@Achanandhi-M Achanandhi-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @saimanoharigodavarty ,
Could you please add a screenshot or video showcasing your changes? I wasn’t able to see any updates in the announcement while reviewing locally.
Also, please fix the DCO and Prettier — the pipelines are failing because of them.

Copy link
Copy Markdown
Member

@amaan-bhati amaan-bhati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and for the time and energy you invested in this PR! We shared our review and feedback a few weeks ago and have not seen any updates since, so we are going to close this to keep the queue manageable.

If you would like to continue working on this, please feel free to reopen the PR after addressing the review feedback, or submit a new one - we would be happy to take another look. There are also plenty of other open issues across the repo where your help would be very welcome.

Thank you again for contributing to Keploy! Feel free to reach out on Slack if you have any questions, want clarification on the feedback, or are looking for something new to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants