Skip to content

Add Apache License 2.0 headers to fluent source files#4831

Merged
brendandburns merged 2 commits into
masterfrom
copilot/fix-license-information
Jun 26, 2026
Merged

Add Apache License 2.0 headers to fluent source files#4831
brendandburns merged 2 commits into
masterfrom
copilot/fix-license-information

Conversation

Copilot AI commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

The client-java-api-fluent sources JAR contained no license headers on any of its ~1,457 generated Java files because the fluent module had spotless entirely disabled (<skip>true</skip>).

Changes

  • fluent/src/main/java/**/*.java — Added Apache License 2.0 header to all 1,457 generated fluent source files.
  • fluent/pom.xml — Replaced the spotless <skip>true</skip> with a targeted license-header-only configuration using combine.self="override" to avoid inheriting the parent's full spotless config (Google Java Format, groovy formatter, wildcard-import checks) that would break generated code style.
  • fluent-gen/generate.sh — Added mvn spotless:apply after code generation so future regenerations automatically pick up license headers.

The resulting spotless config in fluent/pom.xml:

<configuration combine.self="override">
    <java>
        <licenseHeader>
            <content>
/*
Copyright $YEAR The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 ...
*/
            </content>
            <delimiter>package </delimiter>
        </licenseHeader>
    </java>
</configuration>

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 25, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@kubernetes-prow kubernetes-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 25, 2026
Fixes #4819: The client-java-api-fluent sources JAR was missing license
headers because spotless was completely skipped for the fluent module.

- Add license headers to all 1457 generated fluent source files
- Update fluent/pom.xml to enable spotless licenseHeader check only
  (using combine.self=override to avoid inheriting groovy/formatter)
- Update fluent-gen/generate.sh to run spotless:apply after regeneration
@kubernetes-prow kubernetes-prow Bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 25, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from brendandburns. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI changed the title [WIP] Fix missing license information in source jar Add Apache License 2.0 headers to fluent source files Jun 25, 2026
@kubernetes-prow kubernetes-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2026
Copilot AI requested a review from brendandburns June 25, 2026 16:53
@brendandburns brendandburns marked this pull request as ready for review June 25, 2026 23:27
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2026
@kubernetes-prow kubernetes-prow Bot requested a review from yue9944882 June 25, 2026 23:28
@brendandburns brendandburns force-pushed the copilot/fix-license-information branch from 2c74f83 to c4cfd8b Compare June 26, 2026 22:11
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Invalid commit message issues detected

Invalid commit messages

Keywords which can automatically close issues and hashtag(#) mentions are not allowed.

  • c4cfd8b Add Apache License 2.0 headers to fluent source files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 26, 2026
@brendandburns brendandburns merged commit 84c44bc into master Jun 26, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants