Skip to content

Generate 19.0.0-snapshot client#1547

Merged
k8s-ci-robot merged 4 commits into
kubernetes-client:masterfrom
roycaihw:v19-snapshot
Sep 13, 2021
Merged

Generate 19.0.0-snapshot client#1547
k8s-ci-robot merged 4 commits into
kubernetes-client:masterfrom
roycaihw:v19-snapshot

Conversation

@roycaihw

@roycaihw roycaihw commented Sep 13, 2021

Copy link
Copy Markdown
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR is built on top of #1426. Commits generated with:

$ KUBERNETES_BRANCH=release-1.19 CLIENT_VERSION=19.0.0-snapshot DEVELOPMENT_STATUS="3 - Alpha" scripts/release.sh

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 13, 2021
@k8s-ci-robot

k8s-ci-robot commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 13, 2021
@k8s-ci-robot k8s-ci-robot requested a review from yliaog September 13, 2021 05:46
@roycaihw roycaihw mentioned this pull request Sep 13, 2021
Merged
@yliaog

yliaog commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

better to remove commit 5e1e1fd, submit it in the separate PR

@roycaihw

roycaihw commented Sep 13, 2021

Copy link
Copy Markdown
Member Author

/cc @scottilee

@k8s-ci-robot

k8s-ci-robot commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: scottilee.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @scottilee

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roycaihw

roycaihw commented Sep 13, 2021

Copy link
Copy Markdown
Member Author

better to remove commit 5e1e1fd, submit it in the separate PR

Done

@yliaog

yliaog commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit d3de7a8 into kubernetes-client:master Sep 13, 2021
@roycaihw roycaihw deleted the v19-snapshot branch September 13, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roycaihw @k8s-ci-robot @yliaog