Skip to content

Update golang-jwt from v3.2.1 to v4 - #1978

Closed
greut wants to merge 1 commit into
labstack:masterfrom
greut:chore/golang-jwt-4
Closed

Update golang-jwt from v3.2.1 to v4#1978
greut wants to merge 1 commit into
labstack:masterfrom
greut:chore/golang-jwt-4

Conversation

@greut

@greut greut commented Sep 6, 2021

Copy link
Copy Markdown

The v4 branch is backward compatible with the v3.2.2 one and brings nicer go.mod (if anything)

https://github.com/golang-jwt/jwt/blob/main/MIGRATION_GUIDE.md

Signed-off-by: Yoan Blanc <yblanc@edgelab.ch>
@aldas

aldas commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

Will happen in v5.

I think changing to v4 would break casts that (unaware of upgrade) people are using when getting token value from context store. If golang-jwt/v4 is really needed please see workarounds for it #1940

@aldas aldas added the v5 label Sep 8, 2021
@codecov

codecov Bot commented Sep 19, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1978 (7842f5c) into master (7f502b1) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1978      +/-   ##
==========================================
+ Coverage   91.04%   91.23%   +0.19%     
==========================================
  Files          32       33       +1     
  Lines        2802     2886      +84     
==========================================
+ Hits         2551     2633      +82     
- Misses        160      161       +1     
- Partials       91       92       +1     
Impacted Files Coverage Δ
middleware/jwt.go 90.26% <ø> (ø)
echo.go 94.15% <0.00%> (ø)
middleware/request_logger.go 97.56% <0.00%> (ø)
router.go 95.72% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f502b1...7842f5c. Read the comment docs.

@stale

stale Bot commented Jan 9, 2022

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed within a month if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Marked as stale for auto-closing label Jan 9, 2022
@aldas

aldas commented Jan 9, 2022

Copy link
Copy Markdown
Contributor

I'll leave it closed. golang-jwt version has been bumped to v4 in Echo v5 proposal. See this discussion for details #2000

@aldas aldas closed this Jan 9, 2022
@aldas aldas mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Marked as stale for auto-closing v5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants