fix: propagate root RouteNotFound handler to route groups#3037
Open
mayank-dev-15 wants to merge 1 commit into
Open
fix: propagate root RouteNotFound handler to route groups#3037mayank-dev-15 wants to merge 1 commit into
mayank-dev-15 wants to merge 1 commit into
Conversation
When a group has middleware, Group.Use() registers catch-all routes to guarantee middleware execution. Previously these routes always used the hardcoded NotFoundHandler, ignoring any custom RouteNotFound handler set on the root Echo instance. Store the user custom RouteNotFound handler on the Echo struct and use it when registering group catch-all routes, falling back to NotFoundHandler if none was set. Fixes labstack#2485
Contributor
|
you can already do this by custom404Handler := func(c echo.Context) error {
return c.String(http.StatusNotFound, "Custom 404 message")
}
echo.NotFoundHandler = custom404Handler
e.RouteNotFound("/*", custom404Handler) // user's custom 404and groups will use that same customHandler as it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a group has middleware,
Group.Use()registers catch-all routes (""and"/*") to guarantee middleware execution. Previously these routes always used the hardcodedNotFoundHandler, ignoring any customRouteNotFoundhandler set on the rootEchoinstance.Problem
Fix
Store the user's custom
RouteNotFoundhandler on theEchostruct and use it when registering group catch-all routes, falling back toNotFoundHandlerif none was set.Changes
notFoundHandlerfield toEchostruct; set it inRouteNotFound()Use()now usesg.echo.notFoundHandlerinstead of hardcodedNotFoundHandlerFixes #2485