docs(ltv): rework plan around peer generation schemes [LTV-M2]#105
Closed
shaypal5 wants to merge 1 commit into
Closed
docs(ltv): rework plan around peer generation schemes [LTV-M2]#105shaypal5 wants to merge 1 commit into
shaypal5 wants to merge 1 commit into
Conversation
Acts on the maintainer decision that leadforge becomes a platform hosting two
PARALLEL, peer generation schemes (lead_scoring + lifecycle), not a
lead-scoring framework with an LTV bolt-on.
design.md:
- New §2.5 "peer generation schemes": decisions D10 (extract the
GenerationScheme abstraction EARLY, against the known-good lead-scoring path,
output byte-identical) and D11 (physically reorganize into
leadforge/schemes/{lead_scoring,lifecycle}/ now). Adds the scheme→recipe→
bundle hierarchy, the GenerationScheme protocol shape, a shared-envelope vs
per-scheme table, the target package layout, reorg safety rails for the
published 1.x package, and a note that LTV-Pb (#104) already aligns.
- §10 inventory: lifecycle modules now live under schemes/lifecycle/; adds
schemes/base.py; recipe declares scheme: lifecycle.
roadmap.md (reshaped to 9 milestones / ~18 PRs, Pa..Pr):
- New LTV-M2 "Generation-scheme architecture + physical reorg" (LTV-Pd/Pe/Pf):
protocol+registry against lead-scoring → move lead-scoring into
schemes/lead_scoring/ → scaffold schemes/lifecycle/ and relocate the
LTV-Pb/Pc specs.
- Lifecycle build milestones (population/engine/snapshots) renumbered to
M3-M5 and now land directly under schemes/lifecycle/.
- LTV-M6 registers LifecycleScheme end-to-end + recipe + manifest
generation_scheme + schema v6.
.agent-plan.md: scheme-architecture summary + revised status (M2 next; can run
in parallel with M1 since it only touches the existing lead-scoring path).
Stacked on the LTV-Pb branch (#104) because it references that work as done.
No package code in this PR.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
shaypal5
added
type: docs
|
pr-agent-context report: No unresolved review comments, failing checks, or actionable patch coverage gaps were found on PR #105 in repository https://github.com/leadforge-dev/leadforge. Treat this PR as all clear unless new signals appear.Run metadata: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the LTV plan around the maintainer decision that leadforge becomes a
platform hosting two parallel, peer generation schemes (
lead_scoring+lifecycle) — not a lead-scoring framework with an LTV bolt-on. Docs only.Decisions captured (design.md §2.5)
GenerationSchemeabstraction early, against the known-good lead-scoring path (wrap, output byte-identical, hash-determinism guarded) before lifecycle plugs inleadforge/schemes/{lead_scoring,lifecycle}/now (not logical-only)Plus: the scheme → recipe → bundle hierarchy, the
GenerationSchemeprotocol shape, a shared-envelope-vs-per-scheme table, the target package
layout, and reorg safety rails for the published 1.x package (public API
stable, back-compat shims, hash-determinism + full suite green each step).
Roadmap reshape (9 milestones / ~18 PRs,
Pa..Pr)LTV-M2— Generation-scheme architecture + physical reorg(
LTV-Pd/Pe/Pf): protocol + registry against lead-scoring → movelead-scoring into
schemes/lead_scoring/→ scaffoldschemes/lifecycle/andrelocate the
LTV-Pb/LTV-Pcspecs.M3–M5and land directly underschemes/lifecycle/.LTV-M6registersLifecycleSchemeend-to-end + recipe + manifestgeneration_scheme+ schema v6.LTV-M2can begin in parallel withLTV-M1finishing — it only touches theexisting lead-scoring path.
Note on #104
Aligned, not invalidated: #104 already used a separate
LIFECYCLE_ROW_TYPESregistry (the per-scheme-registry model).
LTV-M2relocates those rows intoschemes/lifecycle/entities.py.🤖 Generated with Claude Code