feat: v4-M2 — snapshot day tuning + validation fix + release docs#24
Merged
Conversation
- Change SNAPSHOT_DAY from 14 to 10 to ensure leakage trap boost ≥ 0.03 after the lead-source boost stacking fix changed population distributions - Add StandardScaler to validate_v4_dataset.py LR pipeline to fix convergence warnings - Update .agent-plan.md to mark v4-M1 and v4-M2 complete Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
pr-agent-context report: No unresolved review comments, failing checks, or actionable patch coverage gaps were found on PR
#24. Treat this PR as all clear unless new signals appear.Run metadata: |
There was a problem hiding this comment.
Pull request overview
This PR tunes the v4 dataset build/validation utilities to restore the intended “leakage trap” signal after earlier population distribution changes, and updates internal milestone tracking accordingly.
Changes:
- Adjust the v4 snapshot window from day 14 to day 10 in the build script.
- Add
StandardScalerto the validation script’s LogisticRegression fitting to improve convergence stability. - Update
.agent-plan.mdmilestone status and recorded v4 validation metrics.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/validate_v4_dataset.py | Scales numeric features before fitting LR to stabilize convergence for AUC/leakage-trap checks. |
| scripts/build_v4_snapshot.py | Switches snapshot window constant/docs from day-14 to day-10. |
| .agent-plan.md | Marks v4 milestones complete and updates reported metrics/notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogisticRegressionwas not converging reliably without feature scaling. AddedStandardScalerto_fit_lr()invalidate_v4_dataset.py.leadforge-datasets-private..agent-plan.mdupdated: v4-M1 and v4-M2 marked complete.Test plan
python scripts/build_v4_snapshot.py /tmp/test_v4.csvproduces valid CSVpython scripts/validate_v4_dataset.py /tmp/test_v4.csvexits 0🤖 Generated with Claude Code