Skip to content

Fix approved pr-agent-context refresh runs#26

Merged
shaypal5 merged 2 commits into
mainfrom
codex/pr-agent-refresh-fallback
Apr 30, 2026
Merged

Fix approved pr-agent-context refresh runs#26
shaypal5 merged 2 commits into
mainfrom
codex/pr-agent-refresh-fallback

Conversation

@shaypal5

@shaypal5 shaypal5 commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the pr-agent-context refresh path used after Copilot or other bot-authored reviews land on an open PR.

This specifically addresses the manual Approve Run regression seen on PR #25: GitHub did create a second attempt after approval, but the refresh workflow failed at reusable-workflow validation with startup_failure before any job existed.

The refresh workflow already had direct review triggers and a scheduled dispatcher, but the workflow call still passed the old pull_request_* input names into shaypal5/pr-agent-context/.github/workflows/pr-agent-context.yml@v4. The reusable workflow expects the *_override inputs, so manually approved bot-triggered refresh attempts could fail at workflow startup before any job existed.

Changes

  • Pass pull_request_number_override, pull_request_head_sha_override, and pull_request_base_sha_override to the reusable pr-agent-context workflow.
  • Add trigger_event_name and trigger_event_action dispatch inputs, then forward them as trigger metadata overrides.
  • Make scheduled workflow_dispatch refreshes non-cancelling so fallback dispatches do not churn in-flight runs.
  • Add a run-name that makes scheduled/manual refresh runs easy to dedupe and inspect.
  • Set coverage_source_workflows: CI for cross-run coverage lookup.
  • Send schedule trigger metadata from the dispatcher.
  • Update .agent-plan.md with the expected post-merge state.

Validation

  • python YAML parse of both refresh workflow files passed.
  • git diff --check passed.
  • Commit hooks passed: trim trailing whitespace, end-of-file fixer, YAML check, merge-conflict check.

Notes

actionlint is not installed in the local environment, so validation used YAML parsing and the repository pre-commit YAML check.

Copilot AI review requested due to automatic review settings April 30, 2026 03:45
@shaypal5 shaypal5 added type: ci CI/CD pipeline changes status: needs review Ready for review labels Apr 30, 2026
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the pr-agent-context refresh fallback path by aligning the caller workflow inputs with the reusable shaypal5/pr-agent-context workflow’s expected *_override parameters, and by improving refresh dispatch metadata/concurrency behavior so bot-authored review refreshes reliably start.

Changes:

  • Update refresh workflow to pass pull_request_*_override inputs and forward synthetic trigger metadata.
  • Adjust refresh concurrency so workflow_dispatch fallback runs do not cancel in-flight runs; add a more informative run-name.
  • Update scheduled dispatcher to send schedule trigger metadata and update .agent-plan.md status text.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/pr-agent-context-refresh.yml Fixes reusable-workflow input wiring; adds trigger metadata forwarding, run-name, and non-cancelling dispatch concurrency.
.github/workflows/pr-agent-context-refresh-dispatcher.yml Adds trigger metadata inputs for scheduled redispatches.
.agent-plan.md Notes the intended post-merge state in the project plan.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pr-agent-context-refresh.yml Outdated
Comment thread .github/workflows/pr-agent-context-refresh.yml
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@shaypal5 shaypal5 changed the title Fix pr-agent-context refresh fallback wiring Fix approved pr-agent-context refresh runs Apr 30, 2026
@github-actions

Copy link
Copy Markdown

pr-agent-context report:

No unresolved review comments, failing checks, or actionable patch coverage gaps were found on PR
#26. Treat this PR as all clear unless new signals appear.

Run metadata:

Tool ref: v4
Tool version: 4.0.20
Trigger: commit pushed
Workflow run: 25146825507 attempt 1
Comment timestamp: 2026-04-30T04:07:53.401801+00:00
PR head commit: e68ae781cd36eb37bcdfec92ce15307304a133dc

@shaypal5 shaypal5 merged commit 0eea76b into main Apr 30, 2026
5 checks passed
@shaypal5 shaypal5 deleted the codex/pr-agent-refresh-fallback branch April 30, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs review Ready for review type: ci CI/CD pipeline changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants