Fix approved pr-agent-context refresh runs#26
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Fixes the pr-agent-context refresh fallback path by aligning the caller workflow inputs with the reusable shaypal5/pr-agent-context workflow’s expected *_override parameters, and by improving refresh dispatch metadata/concurrency behavior so bot-authored review refreshes reliably start.
Changes:
- Update refresh workflow to pass
pull_request_*_overrideinputs and forward synthetic trigger metadata. - Adjust refresh concurrency so
workflow_dispatchfallback runs do not cancel in-flight runs; add a more informativerun-name. - Update scheduled dispatcher to send
scheduletrigger metadata and update.agent-plan.mdstatus text.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/pr-agent-context-refresh.yml | Fixes reusable-workflow input wiring; adds trigger metadata forwarding, run-name, and non-cancelling dispatch concurrency. |
| .github/workflows/pr-agent-context-refresh-dispatcher.yml | Adds trigger metadata inputs for scheduled redispatches. |
| .agent-plan.md | Notes the intended post-merge state in the project plan. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
pr-agent-context report: No unresolved review comments, failing checks, or actionable patch coverage gaps were found on PR
#26. Treat this PR as all clear unless new signals appear.Run metadata: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
pr-agent-contextrefresh path used after Copilot or other bot-authored reviews land on an open PR.This specifically addresses the manual Approve Run regression seen on PR #25: GitHub did create a second attempt after approval, but the refresh workflow failed at reusable-workflow validation with
startup_failurebefore any job existed.The refresh workflow already had direct review triggers and a scheduled dispatcher, but the workflow call still passed the old
pull_request_*input names intoshaypal5/pr-agent-context/.github/workflows/pr-agent-context.yml@v4. The reusable workflow expects the*_overrideinputs, so manually approved bot-triggered refresh attempts could fail at workflow startup before any job existed.Changes
pull_request_number_override,pull_request_head_sha_override, andpull_request_base_sha_overrideto the reusablepr-agent-contextworkflow.trigger_event_nameandtrigger_event_actiondispatch inputs, then forward them as trigger metadata overrides.workflow_dispatchrefreshes non-cancelling so fallback dispatches do not churn in-flight runs.run-namethat makes scheduled/manual refresh runs easy to dedupe and inspect.coverage_source_workflows: CIfor cross-run coverage lookup.scheduletrigger metadata from the dispatcher..agent-plan.mdwith the expected post-merge state.Validation
pythonYAML parse of both refresh workflow files passed.git diff --checkpassed.Notes
actionlintis not installed in the local environment, so validation used YAML parsing and the repository pre-commit YAML check.