fix(supervisor-middleware): configure HTTP/2 keepalive on middleware gRPC channel - #5
fix(supervisor-middleware): configure HTTP/2 keepalive on middleware gRPC channel#5letv1nnn wants to merge 1 commit into
Conversation
…gRPC channel Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
Review: does this solve NVIDIA#2474?Yes for the core fix. The four keepalive settings requested in the issue's Proposed Fix are applied to the middleware
Placed on the builder before the TLS branch, so both Gaps vs. the issue
VerdictCorrect, minimal, matches the house pattern. Solves the stated issue. Fix the test-checkbox claim before merge; file a follow-up for the |
Summary
The middleware gRPC channel was the only long-lived client in the repo without HTTP/2 keepalive config. Without it, idle connections are silently reaped by intermediaries and dead peers go undetected until the next evaluation attempt.
This is a prerequisite for NVIDIA#2428 (WebSocket middleware), where long-lived bidirectional streams make a stale connection session-fatal rather than a single-retry inconvenience.
Related Issue
NVIDIA#2474
Changes
http2_keep_alive_interval,keep_alive_while_idle,keep_alive_timeout, andhttp2_adaptive_windowto the Endpoint builder incrates/openshell-supervisor-middleware/src/remote.rs. The configuration is the same as in thecrates/openshell-core/src/grpc_client.rsgRPC channel builder.Testing
mise run pre-commitpassesChecklist