Latest integration from libgit2 breaks access to large repositories

[yishaigalatzer]

Download https://github.com/yishaigalatzer/BlankUmbraco
And try to create a repository/get status etc.

The operation fails because libgit2 says the site is too deeply nested. This worked prior to the latest integration.

I'm opening here rather than on libgit2, because it's much easier for me to repro. Though the issue really is in libgit2

I chatted with Jamill and he though this might come from commit 9bea03ce

[arrbee]

When you file a report like this, can you please include the exact text of the error message from libgit2? Then instead of guessing where the error comes from, we can be precise.

Based on what you're saying, I speculate this is coming from the 100 nested directory limit I put on the working directory iterator. Given windows path limits, I'm surprised to see anyone hitting it, so either there is a bug (eg maybe I forgot to decrement the counter) or the limit is too low. I'll take a further look after lunch.

[yishaigalatzer]

@arrbee there you go.

in Ensure.cs:

                throw new LibGit2SharpException(errorMessage, (GitErrorCode)result, error.Category);

Exception details:

LibGit2Sharp.LibGit2SharpException occurred
HResult=-2146233088
Message=An error was raised by libgit2. Category = Repository (Error).
Working directory is too deep
Source=LibGit2Sharp
StackTrace:
at LibGit2Sharp.Core.Ensure.HandleError(Int32 result) in c:\Users\yigalatz\Documents\GitHub\libgit2sharp\LibGit2Sharp\Core\Ensure.cs:line 77
InnerException:

[yishaigalatzer]

@arrbee I can easily repro by creating more than 100 folders in a repository (flat right under the root) and dropping a single file in each one of them.

[arrbee]

Above PR for libgit2 should fix the problem (and a couple of other related ones that only came up if you had empty directories).

[yishaigalatzer]

Thanks @arrbee it still needs to go into lg2# though

[yishaigalatzer]

I verified the fix in our unit tests and build looks good. Closing as there is an open PR to cover this

[nulltoken]

Thanks a lot for those recent reports!

@yishaigalatzer @ethomson's #362 has been merged.