mono dllimport compatibility

[txdv]

        [DllImport(libgit2)]
        public static extern int git_reference_listall(git_strarray* array, RepositorySafeHandle repo, GitReferenceType flags);

        [DllImport(libgit2)]
        public static extern int git_tag_list(git_strarray* array, RepositorySafeHandle repo);

        [DllImport(libgit2)]
        public static extern void git_strarray_free(git_strarray* array);

Consider changing "git_starray*" "out git_strarray". This will make libgit2sharp run on mono 2.8+.

[nulltoken]

Thanks for reporitng this!

Unfortunately, as the design of git_strarray_free is incompatible with an out parameter, it's been changed into a ref method parameter keyword.

Could you confirm this now works ok on Mono?

[txdv]

Doesn't matter if ref or out.
It just doesn't work when you pass unsafe types (types using pointers) using an unsafe pointer, which is strange.
Already reported in the bug tracker.
For the time being this should work.

[txdv]

Hm my generator generates out for all the free functions because the parameters are not const.
Should the parameters be const in libgit2?

[nulltoken]

Could you confirm this now works ok on Mono?

For the time being this should work.

I'm sorry. I may not have understood your answer. Does this now works correctly?

[nulltoken]

Should the parameters be const in libgit2?

No. One can not free() a const

[txdv]

I'm sorry. I may not have understood your answer. Does this now works correctly?

I'll test it personally with libgit2sharp running the test suite, but when I was deving my lib using * instead of out/ref resulted in runtime exceptions.

No. One can not free() a const

It would be helpful if you could supply a reason why not. Does it change any values at the location, where the pointer is pointing at? Or is a convetion that free has no

[txdv]

        public const string TestRepoPath = "./Resources/testrepo.git";
        public const string TestRepoWithWorkingDirRootPath = "./Resources/testrepo_wd";
        public const string TestRepoWithWorkingDirPath = TestRepoWithWorkingDirRootPath + "/.git";

Path.Combine would be appreciated by the unix fanatics.

[nulltoken]

Path.Combine would be appreciated.

Thanks for pointing at this. Would you be so kind as to open a separate issue?

[nulltoken]

I'll test it personally with libgit2sharp running the test suite

Thanks a lot. That would be very helpful.

[nulltoken]

It would be helpful if you could supply a reason why not.

It makes very little sense from a semantic perspective.

A const specifier implies that the data pointed to by the parameter won't be modified/altered by the function. Calling free() alters the contents of the memory block. See this for further information.

[txdv]

Well it doesn't alter it, it just deletes it entirely.
But I now understand, free doesn't produce create anything new, so out is not the way to go.
I'll have to adjust my generator so I can add overrides for functions like this.

[nulltoken]

Merged in LibGit2Sharp/vNext