Simplify git_revparse_ext usage#1013
Conversation
|
@jamill What's your opinion about this? |
There was a problem hiding this comment.
Should we call GC.SuppressFinalize() at the end of this method?
There was a problem hiding this comment.
Oh! Indeed. Thanks for this
There was a problem hiding this comment.
Actually, I think I was mistaken here - I don't think this is needed.
From Object.Finalize documentation:
The Object class provides no implementation for the Finalize method, and the garbage collector does not mark types derived from Object for finalization unless they override the Finalize method.
|
|
I'll try this out and report back when it's done. |
No description provided.