Try harder to format error messages#1026
Merged
Merged
Conversation
Member
That could also work from an odbBackend |
jamill
force-pushed
the
jamill/set_error
branch
2 times, most recently
from
April 28, 2015 15:49
6f6f0ae to
d36cb2a
Compare
Member
Author
That worked pretty well. How do you feel about the formatting? |
Member
Author
There was a problem hiding this comment.
will add trailing newline...
jamill
force-pushed
the
jamill/set_error
branch
from
April 28, 2015 20:31
d36cb2a to
56028ed
Compare
Also marshals text as UTF8, as expected by libgit2.
jamill
force-pushed
the
jamill/set_error
branch
from
April 28, 2015 20:36
56028ed to
983ce49
Compare
nulltoken
added a commit
that referenced
this pull request
Apr 28, 2015
Try harder to format error messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try harder to capture relevant information when generating error message from an exception. This also marshals text as UTF8, as expected by libgit2.
TODO:
This is currently a private method, so I can't test it as is. I could either 1) expose the method that generates error messages from exceptions as a public utility method, or 2) wire up a sub transport that just throws exceptions and verify the exception message...
/cc @ethomson