Remove manual connection to remote

[Therzok]

As seen in https://github.com/libgit2/libgit2/blob/master/src/remote.c#L2381-L2397

[Therzok]

/cc @nulltoken

[Therzok]

This resulted in double dialog asking for credentials on MonoDevelop, and I traced it back here.

[carlosmn]

The connect called from inside _push() should be a no-op. If it's connecting twice, that would mean it's a bug in libgit2.

[Therzok]

Explanation:

Before, it was not attemping a remote connection if you were connected already to the remote. Now, it always attempts a connection.

[Therzok]

This fixes the issue I was having though, so I'm pretty sure it's getting double connection in libgit2 land. I'm getting the credential callback twice, once from git_remote_connect, once from git_remote_push.

[carlosmn]

That would mean that _connect() tries to connect even though it's already connected, which is a bug, which you're hiding here, rather than fixing.

[Therzok]

Opened an issue on libgit2 side. :P Until then, this works for me.

[nulltoken]

@Therzok The amazing @carlosmn will work on the libgit2 side. Meanwhile, your proposal is sound. Could you please update your commit, and drop git_remote_connect() git_remote_disconnect() from the NativeMethods and Proxy types as well (as git_remote_free() takes care of calling it)?

[Therzok]

@nulltoken it's not used only there.

git_remote_connect() is also used in Network.ListReferences(), which libgit2 doesn't seem to handle for connect/disconnect.

Also, libgit2/libgit2#3096 for reference.

[nulltoken]

@Therzok Sorry. It was a typo. I meant _disconnect()

[Therzok]

Done.

[nulltoken]

👍 🍌

[nulltoken]

Published as NuGet pre-release package LibGit2Sharp.0.22.0-pre20150527180327