Skip to content

Teach Network to list references on a remote#315

Closed
jamill wants to merge 1 commit into
libgit2:vNextfrom
jamill:ls_remote
Closed

Teach Network to list references on a remote#315
jamill wants to merge 1 commit into
libgit2:vNextfrom
jamill:ls_remote

Conversation

@jamill

@jamill jamill commented Feb 6, 2013

Copy link
Copy Markdown
Member

There is a skipped test, it appears that cloning through LibGit2Sharp does not bring down the refs/tags/nearly-dangling reference.

/cc @ben

@ben

ben commented Feb 6, 2013

Copy link
Copy Markdown
Member

Turns out git_clone was using the wrong default for remote autotagging. This is fixed as of libgit2/libgit2@beede43, so the next libgit2 binary update should pick it up.

@nulltoken

Copy link
Copy Markdown
Member

@jamill Very neat!

Just a little concern. It looks like Travis is encountering a little Mono cough. Can you peek at it please?

@ben 💌

@jamill

jamill commented Feb 7, 2013

Copy link
Copy Markdown
Member Author

hmmm... interesting. It appears to be a difference in the layout of the native structure git_remote_head or it's marshalling between Microsoft compilers and what Travis is running. Here is the actual failing comparison, for the OID of the first git_remote_head:

Expected: 49322bb17d3acc9146f98c97d078513228bbf3c0
Actual: b17d3acc9146f98c97d078513228bbf3c0000000

The actual Oid value is shifted.

@jamill

jamill commented Feb 11, 2013

Copy link
Copy Markdown
Member Author

Updated to include base libgit2 updates. The first commit should not be included when merging this PR, but should wait until a proper commit with updated libgit2 binaries is merged in. This should show the updated PR with passing tests.

@jamill

jamill commented Feb 11, 2013

Copy link
Copy Markdown
Member Author

Rebased on top of latest libgit2 binaries!

@nulltoken

Copy link
Copy Markdown
Member

You totally nailed this! 💥

@nulltoken nulltoken closed this Feb 12, 2013
@nulltoken

Copy link
Copy Markdown
Member

Merged.

@jamill
jamill deleted the ls_remote branch February 12, 2013 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants