Skip to content

Add permanent ignore rules to .gitignore.#338

Closed
XaeroDegreaz wants to merge 2 commits into
libgit2:vNextfrom
XaeroDegreaz:vNext
Closed

Add permanent ignore rules to .gitignore.#338
XaeroDegreaz wants to merge 2 commits into
libgit2:vNextfrom
XaeroDegreaz:vNext

Conversation

@XaeroDegreaz

Copy link
Copy Markdown
Contributor

Signed-off-by: Jerome Doby xaerodegreaz@gmail.com

Signed-off-by: Jerome Doby <xaerodegreaz@gmail.com>
Signed-off-by: Jerome Doby <xaerodegreaz@gmail.com>
@XaeroDegreaz

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback -- I'll work on these suggestions.

@nulltoken

Copy link
Copy Markdown
Member

@XaeroDegreaz I've got some mixed feelings about this PR.

To me .gitignore is a complex subject, and I have the feeling that the scope of this PR might be a bit "too narrow" to be merged.

Beside this, we may even lack some proper libgit2 ignore related functions to make this work properly. Making this rely on git_ignore_add_rule may bite us back later.

More information on this topic

@XaeroDegreaz

Copy link
Copy Markdown
Contributor Author

@nulltoken Thanks for looking into this.

After reviewing the links posted, and the feedback here, it's obvious that my PR is not up to snuff for merging, but it works for my purposes alone.

In light of this, I'll close the request since I have other things to push to my fork that shouldn't be tracked by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants