Allow commits on any unparented branch

LibGit2Sharp.Tests/CommitFixture.cs

@@ -618,7 +618,7 @@ public void CanCommitALittleBit()
                 AssertBlobContent(commit[relativeFilepath], "nulltoken\n");
 
                 Assert.Equal(0, commit.Parents.Count());
-                Assert.False(repo.Info.IsEmpty);
+                Assert.False(repo.Info.IsHeadOrphaned);
 
                 File.WriteAllText(filePath, "nulltoken commits!\n");
                 repo.Index.Stage(relativeFilepath);
@@ -814,5 +814,28 @@ public void CanCorrectlyDistinguishAuthorFromCommitter()
                 Assert.Equal(committer, c.Committer);
             }
         }
+
+        [Fact]
+        public void CanCommitOnOrphanedBranch()
+        {
+            string newBranchName = "refs/heads/newBranch";
+            SelfCleaningDirectory scd = BuildSelfCleaningDirectory();
+
+            using (var repo = Repository.Init(scd.DirectoryPath))
+            {
+                // Set Head to point to branch other than master
+                repo.Refs.UpdateTarget("HEAD", newBranchName);
+                Assert.Equal(newBranchName, repo.Head.CanonicalName);
+
+                const string relativeFilepath = "test.txt";
+                string filePath = Path.Combine(repo.Info.WorkingDirectory, relativeFilepath);
+
+                File.WriteAllText(filePath, "test\n");
+                repo.Index.Stage(relativeFilepath);
+
+                repo.Commit("Initial commit", DummySignature, DummySignature);
+                Assert.Equal(1, repo.Head.Commits.Count());
+            }
+        }
     }
 }

LibGit2Sharp.Tests/RepositoryFixture.cs

@@ -150,7 +150,6 @@ public void CreatingRepoWithBadParamsThrows()
         private static void AssertInitializedRepository(Repository repo)
         {
             Assert.NotNull(repo.Info.Path);
-            Assert.True(repo.Info.IsEmpty);
             Assert.False(repo.Info.IsHeadDetached);
             Assert.True(repo.Info.IsHeadOrphaned);
 
@@ -215,7 +214,6 @@ public void CanOpenRepository()
                 Assert.NotNull(repo.Info.Path);
                 Assert.Null(repo.Info.WorkingDirectory);
                 Assert.True(repo.Info.IsBare);
-                Assert.False(repo.Info.IsEmpty);
                 Assert.False(repo.Info.IsHeadDetached);
             }
         }

LibGit2Sharp.Tests/TagFixture.cs

@@ -603,7 +603,7 @@ public void CanListAllTagsInAEmptyRepository()
 
             using (var repo = Repository.Init(scd.DirectoryPath))
             {
-                Assert.True(repo.Info.IsEmpty);
+                Assert.True(repo.Info.IsHeadOrphaned);
                 Assert.Equal(0, repo.Tags.Count());
             }
         }

LibGit2Sharp/Repository.cs

@@ -657,7 +657,7 @@ public void Reset(Commit commit, IEnumerable<string> paths = null)
         /// <returns>The generated <see cref = "Commit" />.</returns>
         public Commit Commit(string message, Signature author, Signature committer, bool amendPreviousCommit = false)
         {
-            if (amendPreviousCommit && Info.IsEmpty)
+            if (amendPreviousCommit && Info.IsHeadOrphaned)
             {
                 throw new LibGit2SharpException("Can not amend anything. The Head doesn't point at any commit.");
             }
@@ -681,7 +681,7 @@ private IEnumerable<Commit> RetrieveParentsOfTheCommitBeingCreated(bool amendPre
                 return Head.Tip.Parents;
             }
 
-            if (Info.IsEmpty)
+            if (Info.IsHeadOrphaned)
             {
                 return Enumerable.Empty<Commit>();
             }

LibGit2Sharp/RepositoryInformation.cs

@@ -1,4 +1,5 @@
-using LibGit2Sharp.Core;
+using System;
+using LibGit2Sharp.Core;
 
 namespace LibGit2Sharp
 {
@@ -51,6 +52,7 @@ internal RepositoryInformation(Repository repo, bool isBare)
         /// <value>
         ///   <c>true</c> if this repository is empty; otherwise, <c>false</c>.
         /// </value>
+        [Obsolete("This method will be removed in the next release.")]
         public virtual bool IsEmpty
         {
             get { return Proxy.git_repository_is_empty(repo.Handle); }