Implicit Operator: GitOid => ObjectId

[dahlbyk]

The only thing we ever do with a GitOid is turn it into an ObjectId, so I figure we might as well make the conversion trivial (and null-friendly, as I have found I need with submodules).

[nulltoken]

Although I'm usually not a big fan of implicit cast (hard to discover and tend to make the code somewhat surprising to read/review), this one can't bite the consumer of the library and cuts off some code noise.

Beside this, the two types bear the exact same meaning 👍

Merged! ❤️

[dahlbyk]

Although I'm usually not a big fan of implicit cast (hard to discover and tend to make the code somewhat surprising to read/review), this one can't bite the consumer of the library and cuts off some code noise.

That was my thought process behind implicit string => FilePath as well.

How do you feel about explicit casts? Specifically, it might be useful to have one for string => ObjectId to simplify test scenarios where InlineData specifies an expected (possibly null) ObjectId as a string.

[nulltoken]

How do you feel about explicit casts? Specifically, it might be useful to have one for string => ObjectId to simplify test scenarios where InlineData specifies an expected (possibly null) ObjectId as a string.

👍