Skip to content

Update libgit2 binaries to b72f5d#360

Merged
nulltoken merged 1 commit into
libgit2:vNextfrom
ethomson:libgit2_update
Mar 11, 2013
Merged

Update libgit2 binaries to b72f5d#360
nulltoken merged 1 commit into
libgit2:vNextfrom
ethomson:libgit2_update

Conversation

@ethomson

@ethomson ethomson commented Mar 6, 2013

Copy link
Copy Markdown
Member

It's been a while!

Comment thread LibGit2Sharp/Core/GitDiff.cs Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It matches the libgit2 enum, but I'll ask anyway... is this supposed to have the same value as GIT_DIFF_RECURSE_UNTRACKED_DIRS?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yow, good eye. I don't actually know.

@arrbee ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @dahlbyk - this is incorrect, and currently unused by libgit2 and this constant probably made it in by accident as a reminder. Removing this from libgit2# for now.

@nulltoken

Copy link
Copy Markdown
Member

It's been a while!

Indeed! 😄

@ethomson Could you please

  • Upgrade the binaries to the latest development tip
  • Add a link to the commit message to the diff between the two two versions (cf. a41d336 for instance)

@ethomson

Copy link
Copy Markdown
Member Author

@nulltoken I'll take a look at it today -- but I fear the changes to refs may require somebody with more C# voodoo than I possess.

@nulltoken

Copy link
Copy Markdown
Member

@ethomson ❤️

Let's not expose the pluggable backend yet and keep the default filesystem based one.
You should not need this trickery any longer.

If you happen to stumble against an issue, do not hesitate to ping me!

@ethomson

Copy link
Copy Markdown
Member Author

@nulltoken See what you think about this... The travis builds don't seem to be liking me, I'll kick them in a bit and see if it starts working.

@nulltoken
nulltoken merged commit ce5ccef into libgit2:vNext Mar 11, 2013
@nulltoken

Copy link
Copy Markdown
Member

@ethomson You have to share some of this C# voodoo you've got with me!

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants