Skip to content

Add Stashes.Remove#375

Merged
nulltoken merged 1 commit into
libgit2:vNextfrom
Saaman:topic/stash-drop
Mar 28, 2013
Merged

Add Stashes.Remove#375
nulltoken merged 1 commit into
libgit2:vNextfrom
Saaman:topic/stash-drop

Conversation

@Saaman

@Saaman Saaman commented Mar 27, 2013

Copy link
Copy Markdown
Contributor

Following my last pull request, here is the code to drop an existing stash.

usage example :
repo.Stashes.Remove("stash@{0}");

Any comment will be appreciated!

Comment thread LibGit2Sharp/Core/Proxy.cs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should encapsulate these two lines in a using (ThreadAffinity()) block

@Saaman

Saaman commented Mar 28, 2013

Copy link
Copy Markdown
Contributor Author

Sorry for my styling mistakes @nulltoken, I am not yet at ease with all the code styles to follow...
I have noticed that travis failed on my last update, but it seems to be network related issues... I'm not completly sure though. Let's wait for the new build to see if it happens again.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential nitpick: "... where is a positive integer" ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saaman Could you include this fix as a separate commit while working on #371?

@nulltoken
nulltoken merged commit 7081cd6 into libgit2:vNext Mar 28, 2013
@nulltoken

Copy link
Copy Markdown
Member

Merged! 🚀

@nulltoken nulltoken mentioned this pull request Apr 3, 2013
@Saaman
Saaman deleted the topic/stash-drop branch April 15, 2013 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants