Skip to content

Identify Reference kind#414

Closed
Saaman wants to merge 3 commits into
libgit2:vNextfrom
Saaman:ref-helpers
Closed

Identify Reference kind#414
Saaman wants to merge 3 commits into
libgit2:vNextfrom
Saaman:ref-helpers

Conversation

@Saaman

@Saaman Saaman commented Apr 26, 2013

Copy link
Copy Markdown
Contributor

Here is a small refactoring around Reference kinds.

@nulltoken

Copy link
Copy Markdown
Member

Merged! 😘

@nulltoken nulltoken closed this Apr 26, 2013
@Saaman
Saaman deleted the ref-helpers branch April 27, 2013 13:41
@jacobaloysious

Copy link
Copy Markdown

Actually I didn't want to use Is... wording for String helpers, as a String is not really a Branch or a Tag

Agree!

How about using KindOf ;-)

@nulltoken

Copy link
Copy Markdown
Member

How about using KindOf ;-)

@jacobaloysious Hmmm. I'm not sure.

We'd need a wording that would express something like "Does this string contains something that would match the naming convention of a [branch|tag|...]?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants