Skip to content

Teach checkout to report notifications#456

Merged
nulltoken merged 2 commits into
libgit2:vNextfrom
jamill:checkout_notify
Jun 25, 2013
Merged

Teach checkout to report notifications#456
nulltoken merged 2 commits into
libgit2:vNextfrom
jamill:checkout_notify

Conversation

@jamill

@jamill jamill commented Jun 20, 2013

Copy link
Copy Markdown
Member

This PR is to expose the checkout notification callback through LibGit2Sharp.

Comment thread LibGit2Sharp/UserCanceledException.cs Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment may not be very appropriate for this type... 😉

@nulltoken

Copy link
Copy Markdown
Member

@jamill Nice! Some small nitpicks, but that's a very nice addition.

While you're at it, could you please take a look at the failed Travis build as well?

@jamill

jamill commented Jun 24, 2013

Copy link
Copy Markdown
Member Author

@nulltoken Thanks! I made the suggested changes and the travis build should pass now as well (will confirm). I still need to rebase this on top of latest, which I will do shortly.

@nulltoken

Copy link
Copy Markdown
Member

@jamill Last nitpick. Could you please convert the File.WriteAllText() calls to leverage the Touch() method?

@jamill

jamill commented Jun 24, 2013

Copy link
Copy Markdown
Member Author

rebased on top of latest and converted to use the Touch(...) method.

Comment thread LibGit2Sharp.Tests/CheckoutFixture.cs Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left over?

@jamill

jamill commented Jun 25, 2013

Copy link
Copy Markdown
Member Author

@nulltoken Thanks again - updated!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamill Could you please value this param xml doc?

@jamill

jamill commented Jun 25, 2013

Copy link
Copy Markdown
Member Author

@nulltoken Updated again. I left the last commit separate - I can squash this commit when necessary.

@nulltoken

Copy link
Copy Markdown
Member

I can squash this commit when necessary.

@jamill Now would be a good time 😉

@jamill

jamill commented Jun 25, 2013

Copy link
Copy Markdown
Member Author

and squashed

@nulltoken
nulltoken merged commit ca7470b into libgit2:vNext Jun 25, 2013
@nulltoken

Copy link
Copy Markdown
Member

and merged

@nulltoken

Copy link
Copy Markdown
Member

and ❤️💥👍🍌‼️

@jamill
jamill deleted the checkout_notify branch June 25, 2013 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants