Skip to content

Cleanup#678

Merged
nulltoken merged 3 commits into
vNextfrom
ntk/obsolete
Apr 16, 2014
Merged

Cleanup#678
nulltoken merged 3 commits into
vNextfrom
ntk/obsolete

Conversation

@nulltoken

Copy link
Copy Markdown
Member
  • Drop obsolete members
  • Fix some issues pinpointed by Code Analysis
  • Upgrade to .Net 4.0
  • Review

@nulltoken

Copy link
Copy Markdown
Member Author

Yeah! Travis seems happy...

Comment thread LibGit2Sharp/Core/GitMergeOpts.cs Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed. I actually untabified the whole file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: the tab fixes were amended into the wrong commit. ;)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duh. Fixed. 😊

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@nulltoken

Copy link
Copy Markdown
Member Author

:shipit: ⁉️

@dahlbyk

dahlbyk commented Apr 16, 2014

Copy link
Copy Markdown
Member

Nitpick aside, 👍

@jamill

jamill commented Apr 16, 2014

Copy link
Copy Markdown
Member

👍

@dahlbyk

dahlbyk commented Apr 16, 2014

Copy link
Copy Markdown
Member

:shipit:

@nulltoken
nulltoken merged commit 6ff7bf8 into vNext Apr 16, 2014
@nulltoken
nulltoken deleted the ntk/obsolete branch April 16, 2014 17:33
@nulltoken nulltoken added this to the v0.18.0 milestone Apr 25, 2014
@nulltoken nulltoken mentioned this pull request Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants