Skip to content

BranchCollection: Obsolete Move and introduce Rename.#738

Merged
nulltoken merged 1 commit into
libgit2:vNextfrom
Therzok:obsoleteMove
Jun 2, 2014
Merged

BranchCollection: Obsolete Move and introduce Rename.#738
nulltoken merged 1 commit into
libgit2:vNextfrom
Therzok:obsoleteMove

Conversation

@Therzok

@Therzok Therzok commented Jun 2, 2014

Copy link
Copy Markdown
Member

This closes #737.

Comment thread LibGit2Sharp/BranchCollection.cs Outdated

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Rename(branch, newName, allowOverwrite)?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nulltoken

Copy link
Copy Markdown
Member

@Therzok Neat! Just a nitpick. It looks like there's still some test code that invokes Branches.Move() in BranchFixture.cs

@Therzok

Therzok commented Jun 2, 2014

Copy link
Copy Markdown
Member Author

Oh? I must've missed it. One second.

@nulltoken

Copy link
Copy Markdown
Member

Last request. Could you please also rename the tests (eg. CanMove -> CanRename, ...)?

@Therzok

Therzok commented Jun 2, 2014

Copy link
Copy Markdown
Member Author

Oh, sure. :D

@Therzok

Therzok commented Jun 2, 2014

Copy link
Copy Markdown
Member Author

Everything should be done now. :o

@nulltoken
nulltoken merged commit 8384e7e into libgit2:vNext Jun 2, 2014
@nulltoken

Copy link
Copy Markdown
Member

...and merged! THANKS! 😄

@nulltoken nulltoken added this to the v0.18.0 milestone Jun 2, 2014
@Therzok
Therzok deleted the obsoleteMove branch June 2, 2014 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants