Replace deprecated MSBuild CreateItem with ItemGroup#758
Merged
Conversation
Member
|
You forgot to modify in https://github.com/libgit2/libgit2sharp/blob/vNext/LibGit2Sharp/LibGit2Sharp.csproj#L334-L339 which is duplicate code. |
Member
Author
|
You're completely correct. ZOMG! It's been here for ages.... |
Member
|
This won't work on the bots with 2.10. |
Member
|
Just a tip: If you want Mac binaries in to be included just like Native binaries for fast development, you can add a submodule to: https://github.com/mono/libgit-binary I'll keep it up-to-date with vNext of libgit2sharp. |
nulltoken
force-pushed
the
ntk/mono3_build_issues
branch
from
January 5, 2015 12:55
5427919 to
3252209
Compare
Member
Author
|
Rebased |
nulltoken
changed the title
nulltoken
force-pushed
the
ntk/mono3_build_issues
branch
from
January 5, 2015 19:45
3252209 to
1e9fd4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial follow up to #733.
.targetsfiles and the different flavors of Mono.Related: