Skip to content

.editorconfig added to repository#812

Merged
nulltoken merged 1 commit into
libgit2:vNextfrom
KindDragon:patch-2
Sep 3, 2014
Merged

.editorconfig added to repository#812
nulltoken merged 1 commit into
libgit2:vNextfrom
KindDragon:patch-2

Conversation

@KindDragon

Copy link
Copy Markdown
Contributor

This simplify working on several projects

@nulltoken

Copy link
Copy Markdown
Member

editorconfig/editorconfig-visualstudio#7 added support for insert_final_newline setting.

Could you please tweak the file in order to account for this as well?

@KindDragon

Copy link
Copy Markdown
Contributor Author

insert_final_newline for all files or only for *.cs?

@nulltoken

Copy link
Copy Markdown
Member

I'd say all text files: cs, txt, md, cmd, sh, ps1 (I may have have forgotten some...)

I'm not sure about .sln and .csproj though. I've always been under the impression that VS kept fighting with me on this topic by normalizing the files....

@ethomson

ethomson commented Sep 2, 2014

Copy link
Copy Markdown
Member

I've always been under the impression that VS kept fighting with me on this topic by normalizing the files....

Indeed it will.

@KindDragon

Copy link
Copy Markdown
Contributor Author

I'd say all text files: cs, txt, md, cmd, sh, ps1 (I may have have forgotten some...)

I'll add it. I always remove final line from text files :-)

@nulltoken

Copy link
Copy Markdown
Member

There's also a famous rant from Linus on this topic, but my google-fu seems lacky today (@carlosmn?)

@carlosmn

carlosmn commented Sep 2, 2014

Copy link
Copy Markdown
Member

I don't recall a rant from Linus (though I expect it must exist). There was that one time when Junio quoted POSIX at me. Turns out that if you don't have a final newline, your file is not actually a text file.

@nulltoken

Copy link
Copy Markdown
Member

@dahlbyk @Therzok Thoughts?

@dahlbyk

dahlbyk commented Sep 2, 2014

Copy link
Copy Markdown
Member

Nothing to add

@Therzok

Therzok commented Sep 2, 2014

Copy link
Copy Markdown
Member

Other than the fact that MonoDevelop/Xamarin Studio don't care about it, it's good to go.

@nulltoken
nulltoken merged commit 4a4d2a9 into libgit2:vNext Sep 3, 2014
@nulltoken

Copy link
Copy Markdown
Member

@KindDragon 🆒 🍌

@Therzok If something similar can be done through configuration for MonoDevelop, could you please wrap it into a PR?

@nulltoken nulltoken added this to the v0.20 milestone Sep 3, 2014
@KindDragon
KindDragon deleted the patch-2 branch September 3, 2014 06:36
@Therzok

Therzok commented Sep 3, 2014

Copy link
Copy Markdown
Member

@nulltoken I think this is done through .sln.DotSettings but don't take my word on it just yet.

@nulltoken

Copy link
Copy Markdown
Member

@Therzok Huh? I thought .DotSettings was a ReSharper only config file (cf. https://github.com/mono/monodevelop/blob/master/main/Main.sln.DotSettings)

@Therzok

Therzok commented Sep 3, 2014

Copy link
Copy Markdown
Member

global settings in Main.sln (GlobalSection(MonoDevelopProperties)) handles this.

Sorry, it's one of those days where I'm being a complete retard due to lack of sleep.

@nulltoken

Copy link
Copy Markdown
Member

@Therzok Got it. Thanks 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants