Skip to content

Implement repo.Describe()#848

Merged
nulltoken merged 2 commits into
vNextfrom
ntk/describe
Feb 1, 2015
Merged

Implement repo.Describe()#848
nulltoken merged 2 commits into
vNextfrom
ntk/describe

Conversation

@nulltoken

@nulltoken nulltoken commented Jan 14, 2015

Copy link
Copy Markdown
Member

Now that libgit2/libgit2#2592 is merged, let's make this available to LibGit2Sharp.

@nulltoken nulltoken changed the title Implement repo.Describe() [WIP] Implement repo.Describe() Jan 14, 2015
nulltoken
nulltoken reviewed Jan 15, 2015
View reviewed changes
Comment thread LibGit2Sharp/IRepository.cs

@nulltoken nulltoken Jan 15, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal should be in a separate commit

@nulltoken nulltoken Jan 16, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@nulltoken

nulltoken commented Jan 15, 2015

Copy link
Copy Markdown
Member Author

Although this lacks some xml doc, I think it's more or less ready for review

@nulltoken nulltoken added this to the v0.21 milestone Jan 15, 2015
@nulltoken

nulltoken commented Jan 16, 2015

Copy link
Copy Markdown
Member Author 
  •    public static string git_describe_commit(

  •        RepositorySafeHandle repo,

  •        ObjectId committishId,

  •        DescribeOptions options)

  •    {

  •        Ensure.ArgumentConformsTo(options.MinimumCommitIdAbbreviatedSize,

Ensure.ArgumentInt32 ?

@Therzok Better?

@Therzok

Therzok commented Jan 16, 2015

Copy link
Copy Markdown
Member

Yeah, better. I had removed the comment since it only had ResultInt32 in Ensure. Probably going to be useful later on, that's why I asked.

jamill
jamill reviewed Jan 20, 2015
View reviewed changes
Comment thread LibGit2Sharp/DescribeOptions.cs Outdated

@jamill jamill Jan 20, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elligible => eligible

@nulltoken nulltoken Jan 24, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@nulltoken

nulltoken commented Jan 24, 2015

Copy link
Copy Markdown
Member Author

Xml doc has been finalized.

Ready for final review.

@nulltoken nulltoken changed the title [WIP] Implement repo.Describe() Implement repo.Describe() Jan 24, 2015
@nulltoken

nulltoken commented Jan 26, 2015

Copy link
Copy Markdown
Member Author

Rebased. Good to go?

@nulltoken
nulltoken merged commit 22bf587 into vNext Feb 1, 2015
@nulltoken
nulltoken deleted the ntk/describe branch February 1, 2015 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.21

Development

Successfully merging this pull request may close these issues.

3 participants

@nulltoken @Therzok @jamill