Why no GTRemote.updatePushURLString:?

[Uncommon]

Is there any particular reason why GTRemote has updateURLString but no updatePushURLString?

I'll gladly do a pull request. It looks pretty straightforward.

[phatblat]

There's -setPushURLString: Does that do what you want?

Ben Chatelain
Sent with Airmail

On July 8, 2016 at 2:19:51 PM, David Catmull (notifications@github.com)
wrote:

Is there any particular reason why GTRemote has updateURLString but no
updatePushURLString?

I'll gladly do a pull request. It looks pretty straightforward.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#583, or mute the thread
https://github.com/notifications/unsubscribe/AABwsxn_DMdFFm8CXPdAmCL4Za7JKWOxks5qTrDngaJpZM4JIXSm
.

[Uncommon]

Aha, yes. I think when I saw updateURLString, then I assumed that pushURLString was a read-only property.

So why do we have both setURLString and updateURLString?

[phatblat]

Looks like the -set methods (property accessors) completely ignore any errors, but updateURLString checks for an error and returns NO when the update failed.

[Uncommon]

Looking at the history, apparently the writable version of the properties was added later. I think it would be good to have updatePushURLString, both for completeness and because it's good to know about errors. I'll go ahead and do that.

[Uncommon]

Done in #585