feat: report which address each ping test used under --debug - #128
Merged
Conversation
BKPepe
force-pushed
the
feat/report-resolved-address
branch
2 times, most recently
from
August 11, 2026 08:33
c856da5 to
8eab70a
Compare
IPv4 and IPv6 can take different paths through the network, so a result is not fully described by the hostname it was measured against. Nothing in the output says which was used: --json carries no client address, and the human-readable line only shows it by accident, in the ISP string. It is not academic. Against speedtest.cesnet.cz the ICMP ping goes over IPv4 while the transfers go over IPv6, so the reported latency and the reported throughput describe two different paths. The ICMP path reports the address the pinger resolved and probed; the TCP path reports every distinct peer the sockets connected to, taken from httptrace. The requests usually share one connection, but a reconnect can land on a different address, and reporting only the first would describe a connection the later samples did not use. Both paths are covered because --no-icmp is common enough that doing only the ICMP one would leave most users with nothing.
BKPepe
force-pushed
the
feat/report-resolved-address
branch
from
August 11, 2026 08:45
8eab70a to
04a16c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPv4 and IPv6 can take different paths through the network, so a result is
not fully described by the hostname it was measured against. Nothing in the
output says which was used —
--jsoncarries no client address, and thehuman-readable line only shows it by accident, inside the ISP string.
It is not academic. Against
speedtest.cesnet.cz, in the same run:The ICMP ping resolves separately from the HTTP client, so the reported
latency and the reported throughput can describe two different paths.
The ICMP path reports the address the pinger resolved and probed; the TCP
path reports the peer the socket actually connected to, taken from
httptrace. Both are covered because--no-icmpis common enough thatdoing only the ICMP one would leave most users with nothing.