feat: report the ping distribution under --debug - #130
Open
BKPepe wants to merge 1 commit into
Open
Conversation
The test reports one average, which says nothing about how the samples were spread. A link averaging 5 ms because every probe took 5 ms and one averaging 5 ms because probes ranged from 1 to 30 ms are not the same link, and only the second explains a connection that feels unsteady. pro-bing already works min, max and standard deviation out in Statistics(), so this prints what is on hand. Replies are shown as a raw count rather than a loss percentage. Ten probes are too few to express as a rate, and ICMP is frequently policed separately from the data path, so a percentage would describe the server's ICMP handling more than the network.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--debugreports a single average ping. That says nothing about how thesamples were spread, and the spread is usually what someone running with
--debugis trying to see: a link averaging 5 ms because every probe took5 ms and one averaging 5 ms because probes ranged from 1 to 30 ms are not the
same link.
pro-bing already computes min, max and standard deviation in
Statistics(),so this prints what is on hand:
Replies are a raw count rather than a loss percentage. Ten probes are too few
to express as a rate, and ICMP is frequently policed separately from the data
path, so a percentage would describe the server's ICMP handling more than the
network.
ICMP only —
PingAndJitter()measures over HTTP and has no equivalent figuresto report.