feat: name the platform in the User-Agent - #131
Merged
Conversation
A server's telemetry stores the User-Agent header already, but the client only
identifies itself by name and version, so an operator cannot tell which kinds
of machine are measuring against them. Browsers have always reported this.
Append the operating system and architecture, which runtime.GOOS and
runtime.GOARCH give as compile-time constants at no cost:
librespeed-cli/1.0.12 (linux; arm64)
It stays coarse on purpose. The kernel version or the hostname would identify
the machine rather than describe it, and nothing here needs that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A server's telemetry stores the
User-Agentheader already, but the clientidentifies itself only by name and version, so an operator cannot tell what kind
of machine is measuring against them. Browsers have always reported this.
runtime.GOOSandruntime.GOARCHare compile-time constants, so this costsnothing:
Verified on the wire against a local server that logs the header, and
cross-built for
linux/arm64,linux/mipsandlinux/ppc64le.It stays coarse on purpose — the kernel version or the hostname would identify
the machine rather than describe it.