more modernization on packaging#24
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the project’s packaging setup by adding a minimal pyproject.toml for PEP 517 builds and adjusting setup.py to avoid importing the module at build time while improving the long description source.
Changes:
- Add
pyproject.tomlwith a setuptools build backend. - Update
setup.pyto extract version via regex fromlunardate.pyand useREADME.mdas the long description. - Remove committed
lunardate.egg-info/*artifacts and update.gitignoreto ignore the entire egg-info directory.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Avoids importing lunardate during build; reads version from source file; switches long description to README. |
| pyproject.toml | Introduces PEP 517 build-system configuration for setuptools. |
| lunardate.egg-info/top_level.txt | Removes generated/committed packaging artifact. |
| lunardate.egg-info/SOURCES.txt | Removes generated/committed packaging artifact. |
| lunardate.egg-info/dependency_links.txt | Removes generated/committed packaging artifact. |
| .gitignore | Ignores the whole lunardate.egg-info directory going forward. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.