BOLT 2 : SHOULD fail an HTLC which has timed out.

[ariard]

While reviewing, I had a doubt, where do we implement initiation of our own of removing timeout incoming HTLCs ? Seems not to be present in any block_connected callbacks right ?

[TheBlueMatt]

Indeed, not yet implemented anywhere. We should also time out pending holding cell HTLCs which we want to add to a channel but fail as we're AwaitingRemoteRAA.

[TheBlueMatt]

This is basically addressed by #441. Its true that we still may not fail a timed-out htlc when the outbound forwarded leg hasn't yet resolved on-chain, but I think that is the correct behavior.