Skip to content

Add liquidity checks and improve payment error handling#3175

Open
slanesuke wants to merge 14 commits into
lightningdevkit:mainfrom
slanesuke:2024-07-abort-insufficient-funds-bolt12
Open

Add liquidity checks and improve payment error handling#3175
slanesuke wants to merge 14 commits into
lightningdevkit:mainfrom
slanesuke:2024-07-abort-insufficient-funds-bolt12

Update docs for `Bolt12SemanticError::InvalidAmount`

35e3daa
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 2, 2026 in 0s

89.59% (-0.04%) compared to 43e28fe

View this Pull Request on Codecov

89.59% (-0.04%) compared to 43e28fe

Details

Codecov Report

❌ Patch coverage is 88.41463% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.59%. Comparing base (43e28fe) to head (35e3daa).
⚠️ Report is 3202 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channelmanager.rs 82.43% 9 Missing and 4 partials ⚠️
lightning/src/ln/offers_tests.rs 96.49% 2 Missing ⚠️
lightning/src/offers/invoice.rs 77.77% 2 Missing ⚠️
lightning/src/offers/invoice_request.rs 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3175      +/-   ##
==========================================
- Coverage   89.63%   89.59%   -0.04%     
==========================================
  Files         127      127              
  Lines      103531   103664     +133     
  Branches   103531   103664     +133     
==========================================
+ Hits        92795    92874      +79     
- Misses       8043     8084      +41     
- Partials     2693     2706      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov