Skip to content

Doxygen second pass: coverage, improvements, fixes, etc.#142

Merged
alan-george-lk merged 30 commits into
mainfrom
feature/more_docs
May 28, 2026
Merged

Doxygen second pass: coverage, improvements, fixes, etc.#142
alan-george-lk merged 30 commits into
mainfrom
feature/more_docs

Conversation

@alan-george-lk
Copy link
Copy Markdown
Collaborator

@alan-george-lk alan-george-lk commented May 27, 2026

Added:

  • scripts/generate-docs.sh: like the clang-* tools before, helper script for generating Doxygen locally and in CI
  • generate-docs.yml workflow stage that validates documentation generates and has no errors, which will catch broken refs, incomplete docs, etc.
  • Added missing doc comments to cover all classes

Changes:

  • Moved Doxygen files from docs/ to docs/doxygen. This was a strategic decision such that docs/ could also hold plain .md files for developer/design reference, such as the Rust SDK/common repo convention

(rendering changes below)

  • Cleaned up side bar (LiveKit C++ SDK was duplicated in the tree)
  • Properly embedded README.md in the docs, which matches JS SDK. The GitHub light/dark mode logo rendered wrong

Fixes:

  • Existing class comments now parse right, such that all classes in the Class List view have entries
  • Styling issues, broken links, favicon locally

Before

Tree (redundant and no version):

Screenshot 2026-05-27 at 10 25 14 PM

Examples (broken links):

Screenshot 2026-05-27 at 10 25 31 PM

After

Screenshot 2026-05-28 at 1 52 38 PM

Comment thread .github/workflows/publish-docs.yml Fixed
Comment thread .github/workflows/validate-docs.yml Fixed
Copy link
Copy Markdown
Collaborator

@stephen-derosa stephen-derosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just reviewed agents/code changes. Still need to go through the GHA and docs/ work but lookig great!

Comment thread scripts/generate-docs.sh
Comment thread include/livekit/video_stream.h
Comment thread include/livekit/remote_track_publication.h Outdated
Comment thread include/livekit/local_track_publication.h
@alan-george-lk alan-george-lk marked this pull request as ready for review May 28, 2026 15:27
Copy link
Copy Markdown
Collaborator

@stephen-derosa stephen-derosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small commands but lgtm!

Comment thread .github/workflows/generate-docs.yml Outdated
Comment thread .github/workflows/publish-docs.yml
Comment thread .github/workflows/publish-docs.yml
Comment thread docs/doxygen/index.md
@stephen-derosa
Copy link
Copy Markdown
Collaborator

image any way to get rid of the `9417...` trailing `v0.4.0` ?

@alan-george-lk alan-george-lk merged commit bb40ec7 into main May 28, 2026
40 of 43 checks passed
@alan-george-lk alan-george-lk deleted the feature/more_docs branch May 28, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants