Add token source API for fetching LiveKit tokens#177
Draft
alan-george-lk wants to merge 4 commits into
Draft
Conversation
xianshijing-lk
left a comment
xianshijing-lk
left a comment
Collaborator
There was a problem hiding this comment.
might need help to understand the TokenSource a bit more
| /// | ||
| /// Invoked on the application thread during @ref Room::connect before the FFI | ||
| /// connect request is sent. The returned future must resolve to a non-empty JWT. | ||
| using TokenSource = std::function<std::future<std::string>()>; |
Collaborator
There was a problem hiding this comment.
I don't really understand this TokenSource impl, is it supposed to be implemented by our developers ? or we can use some implementation in Rust ?
Collaborator
Author
There was a problem hiding this comment.
This was a bad first pass -- I reviewed the code last night and felt the same. Working on a proper implementation and will request your review when actually ready :)
alan-george-lk
force-pushed
the
feature/token_source_api
branch
from
c35572a to
2ec2781
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP